chrome/browser/extensions/menu_manager.h - Issue 359493005: Extend contextMenus API to support browser/page actions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/menu_manager.h

Issue 359493005: Extend contextMenus API to support browser/page actions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/extension_context_menu_model_unittest.cc ('k') | chrome/browser/extensions/menu_manager_factory.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/menu_manager.h

diff --git a/chrome/browser/extensions/menu_manager.h b/chrome/browser/extensions/menu_manager.h

index 23a922a812775e70cced1f5a08255dce666528bd..25feb8f288f2794e37e43d5711637c73909dd3bd 100644

--- a/chrome/browser/extensions/menu_manager.h

+++ b/chrome/browser/extensions/menu_manager.h

@@ -94,7 +94,9 @@ class MenuItem {

VIDEO = 64,

AUDIO = 128,

FRAME = 256,

- LAUNCHER = 512

+ LAUNCHER = 512,

+ BROWSER_ACTION = 1024,

+ PAGE_ACTION = 2048

};

// An item can be only one of these types.

@@ -167,7 +169,7 @@ class MenuItem {

const Id& id() const { return id_; }

Id* parent_id() const { return parent_id_.get(); }

int child_count() const { return children_.size(); }

- ContextList contexts() const { return contexts_; }

+ const ContextList& contexts() const { return contexts_; }

Type type() const { return type_; }

bool checked() const { return checked_; }

bool enabled() const { return enabled_; }