Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Unified Diff: chrome/browser/extensions/context_menu_matcher.h

Issue 359493005: Extend contextMenus API to support browser/page actions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/context_menu_matcher.h
diff --git a/chrome/browser/extensions/context_menu_matcher.h b/chrome/browser/extensions/context_menu_matcher.h
index f3f631fc9181eba56f0cee0fb596fec505da4ee7..ef44dac9df0512aaccb23ae7b66d06cd5d450631 100644
--- a/chrome/browser/extensions/context_menu_matcher.h
+++ b/chrome/browser/extensions/context_menu_matcher.h
@@ -43,10 +43,13 @@ class ContextMenuMatcher {
// This is a helper function to append items for one particular extension.
// The |index| parameter is used for assigning id's, and is incremented for
- // each item actually added.
+ // each item actually added. |is_action_menu| is used for browser and page
+ // action context menus, in which menu items are not placed in submenus
+ // and the extension's icon is not shown.
void AppendExtensionItems(const MenuItem::ExtensionKey& extension_key,
const base::string16& selection_text,
- int* index);
+ int* index,
+ bool is_action_menu);
void Clear();
@@ -80,7 +83,8 @@ class ContextMenuMatcher {
bool can_cross_incognito,
const base::string16& selection_text,
ui::SimpleMenuModel* menu_model,
- int* index);
+ int* index,
+ bool is_action_menu_top_level);
// Attempts to get an MenuItem given the id of a context menu item.
extensions::MenuItem* GetExtensionMenuItem(int id) const;

Powered by Google App Engine
This is Rietveld 408576698