chrome/browser/extensions/api/context_menus/context_menus_api_helpers.cc - Issue 359493005: Extend contextMenus API to support browser/page actions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/context_menus/context_menus_api_helpers.cc

Issue 359493005: Extend contextMenus API to support browser/page actions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Small fixes Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/api/context_menus/context_menus_api_helpers.h ('K') | « chrome/browser/extensions/api/context_menus/context_menus_api_helpers.h ('k') | chrome/browser/extensions/context_menu_matcher.h » ('j') | chrome/browser/extensions/context_menu_matcher.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/context_menus/context_menus_api_helpers.cc

diff --git a/chrome/browser/extensions/api/context_menus/context_menus_api_helpers.cc b/chrome/browser/extensions/api/context_menus/context_menus_api_helpers.cc

index 45ab85ed1e8f39074219a756c186cd62c780c1f2..7284e6286202b4b93dcddf3467b04a12732d4b24 100644

--- a/chrome/browser/extensions/api/context_menus/context_menus_api_helpers.cc

+++ b/chrome/browser/extensions/api/context_menus/context_menus_api_helpers.cc

@@ -17,6 +17,8 @@ const char kDuplicateIDError[] =

const char kGeneratedIdKey[] = "generatedId";

const char kLauncherNotAllowedError[] =

"Only packaged apps are allowed to use 'launcher' context";

+const char kActionNotAllowedError[] =

Devlin 2014/07/24 21:51:26 here too, A < L

gpdavis 2014/07/28 21:08:21 Done.

Devlin 2014/07/29 20:49:45 A < G, too.

gpdavis 2014/07/30 20:53:02 Oops, that was a very negligent mistake. Sorry ab

+ "Only extensions are allowed to use action contexts";

const char kOnclickDisallowedError[] = "Extensions using event pages cannot "

"pass an onclick parameter to chrome.contextMenus.create. Instead, use "

"the chrome.contextMenus.onClicked event.";