Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(250)

Unified Diff: chrome/browser/renderer_context_menu/render_view_context_menu.cc

Issue 359493005: Extend contextMenus API to support browser/page actions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Removed icons Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/renderer_context_menu/render_view_context_menu.cc
diff --git a/chrome/browser/renderer_context_menu/render_view_context_menu.cc b/chrome/browser/renderer_context_menu/render_view_context_menu.cc
index 672fde34428a8d52d454ef7d0f498d0586c029df..bc6dc47cdb12ba085bce8f83e21d80b88970489d 100644
--- a/chrome/browser/renderer_context_menu/render_view_context_menu.cc
+++ b/chrome/browser/renderer_context_menu/render_view_context_menu.cc
@@ -554,17 +554,12 @@ void RenderViewContextMenu::AppendAllExtensionItems() {
l10n_util::SortStrings16(app_locale, &sorted_menu_titles);
int index = 0;
- base::TimeTicks begin = base::TimeTicks::Now();
- for (size_t i = 0; i < sorted_menu_titles.size(); ++i) {
- const std::string& id = map_ids[sorted_menu_titles[i]];
- const MenuItem::ExtensionKey extension_key(id);
+ for (std::vector<base::string16>::iterator it = sorted_menu_titles.begin();
+ it != sorted_menu_titles.end(); ++it) {
+ const std::string& id = map_ids[*it];
extension_items_.AppendExtensionItems(
- extension_key, printable_selection_text, &index);
+ MenuItem::ExtensionKey(id), printable_selection_text, &index);
}
-
- UMA_HISTOGRAM_TIMES("Extensions.ContextMenus_BuildTime",
- base::TimeTicks::Now() - begin);
- UMA_HISTOGRAM_COUNTS("Extensions.ContextMenus_ItemCount", index);
}
void RenderViewContextMenu::AppendCurrentExtensionItems() {

Powered by Google App Engine
This is Rietveld 408576698