Extend contextMenus API to support browser/page actions

chrome/browser/renderer_context_menu/render_view_context_menu.cc

Index: chrome/browser/renderer_context_menu/render_view_context_menu.cc
diff --git a/chrome/browser/renderer_context_menu/render_view_context_menu.cc b/chrome/browser/renderer_context_menu/render_view_context_menu.cc
index 672fde34428a8d52d454ef7d0f498d0586c029df..d4c7561fc7eb77a06cd64cfbb7cb4cf2683dc15f 100644
--- a/chrome/browser/renderer_context_menu/render_view_context_menu.cc
+++ b/chrome/browser/renderer_context_menu/render_view_context_menu.cc
@@ -554,17 +554,13 @@ void RenderViewContextMenu::AppendAllExtensionItems() {
   l10n_util::SortStrings16(app_locale, &sorted_menu_titles);
 
   int index = 0;
-  base::TimeTicks begin = base::TimeTicks::Now();
-  for (size_t i = 0; i < sorted_menu_titles.size(); ++i) {
-    const std::string& id = map_ids[sorted_menu_titles[i]];
+  std::vector<base::string16>::iterator it;

[Devlin, 2014/07/09 22:42:59]

same comment about scoping.

[gpdavis, 2014/07/10 00:22:26]

Done.

+  for (it = sorted_menu_titles.begin(); it != sorted_menu_titles.end(); ++it) {
+    const std::string& id = map_ids[*it];
     const MenuItem::ExtensionKey extension_key(id);

[Devlin, 2014/07/09 22:42:59]

Since you're here... same comment about inlining extension_key. :)

[gpdavis, 2014/07/10 00:22:25]

Done.

     extension_items_.AppendExtensionItems(
         extension_key, printable_selection_text, &index);
   }
-
-  UMA_HISTOGRAM_TIMES("Extensions.ContextMenus_BuildTime",
-                      base::TimeTicks::Now() - begin);
-  UMA_HISTOGRAM_COUNTS("Extensions.ContextMenus_ItemCount", index);
 }
 
 void RenderViewContextMenu::AppendCurrentExtensionItems() {