OLD | NEW |
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. | 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. |
2 // Use of this source code is governed by a BSD-style license that can be | 2 // Use of this source code is governed by a BSD-style license that can be |
3 // found in the LICENSE file. | 3 // found in the LICENSE file. |
4 | 4 |
5 #include "chrome/browser/extensions/extension_context_menu_model.h" | 5 #include "chrome/browser/extensions/extension_context_menu_model.h" |
6 | 6 |
7 #include "chrome/browser/extensions/extension_service.h" | 7 #include "chrome/browser/extensions/extension_service.h" |
8 #include "chrome/browser/extensions/extension_service_test_base.h" | 8 #include "chrome/browser/extensions/extension_service_test_base.h" |
| 9 #include "chrome/browser/extensions/menu_manager.h" |
| 10 #include "chrome/browser/extensions/menu_manager_factory.h" |
9 #include "chrome/browser/ui/browser.h" | 11 #include "chrome/browser/ui/browser.h" |
10 #include "chrome/browser/ui/host_desktop.h" | 12 #include "chrome/browser/ui/host_desktop.h" |
| 13 #include "chrome/common/extensions/api/context_menus.h" |
11 #include "chrome/test/base/test_browser_window.h" | 14 #include "chrome/test/base/test_browser_window.h" |
12 #include "chrome/test/base/testing_profile.h" | 15 #include "chrome/test/base/testing_profile.h" |
13 #include "extensions/browser/extension_system.h" | 16 #include "extensions/browser/extension_system.h" |
14 #include "extensions/browser/test_management_policy.h" | 17 #include "extensions/browser/test_management_policy.h" |
15 #include "extensions/common/extension_builder.h" | 18 #include "extensions/common/extension_builder.h" |
16 #include "extensions/common/value_builder.h" | 19 #include "extensions/common/value_builder.h" |
17 #include "testing/gtest/include/gtest/gtest.h" | 20 #include "testing/gtest/include/gtest/gtest.h" |
18 | 21 |
19 namespace extensions { | 22 namespace extensions { |
20 namespace { | |
21 | 23 |
22 class ExtensionContextMenuModelTest : public ExtensionServiceTestBase { | 24 class ExtensionContextMenuModelTest : public ExtensionServiceTestBase { |
| 25 public: |
| 26 ExtensionContextMenuModelTest(); |
| 27 |
| 28 // Build an extension to pass to the menu constructor. It needs an |
| 29 // ExtensionAction. |
| 30 scoped_refptr<Extension> BuildExtension(); |
| 31 |
| 32 // Creates an extension menu item for |extension| with the given |context| |
| 33 // and adds it to |manager|. Refreshes |model| to show new item. |
| 34 void AddContextItemAndRefreshModel(MenuManager* manager, |
| 35 Extension* extension, |
| 36 MenuItem::Context context, |
| 37 ExtensionContextMenuModel* model); |
| 38 |
| 39 // Reinitializes the given |model|. |
| 40 void RefreshMenu(ExtensionContextMenuModel* model); |
| 41 |
| 42 // Returns the number of extension menu items that show up in |model|. |
| 43 int CountExtensionItems(ExtensionContextMenuModel* model); |
| 44 |
| 45 private: |
| 46 int cur_id_; |
23 }; | 47 }; |
24 | 48 |
| 49 ExtensionContextMenuModelTest::ExtensionContextMenuModelTest() : cur_id_(0) { |
| 50 } |
| 51 |
| 52 scoped_refptr<Extension> ExtensionContextMenuModelTest::BuildExtension() { |
| 53 return ExtensionBuilder() |
| 54 .SetManifest(DictionaryBuilder() |
| 55 .Set("name", "Page Action Extension") |
| 56 .Set("version", "1") |
| 57 .Set("manifest_version", 2) |
| 58 .Set("page_action", |
| 59 DictionaryBuilder().Set("default_title", "Hello"))) |
| 60 .Build(); |
| 61 } |
| 62 |
| 63 void ExtensionContextMenuModelTest::AddContextItemAndRefreshModel( |
| 64 MenuManager* manager, |
| 65 Extension* extension, |
| 66 MenuItem::Context context, |
| 67 ExtensionContextMenuModel* model) { |
| 68 MenuItem::Type type = MenuItem::NORMAL; |
| 69 MenuItem::ContextList contexts(context); |
| 70 const MenuItem::ExtensionKey key(extension->id()); |
| 71 MenuItem::Id id(false, key); |
| 72 id.uid = ++cur_id_; |
| 73 manager->AddContextItem(extension, |
| 74 new MenuItem(id, |
| 75 "test", |
| 76 false, // checked |
| 77 true, // enabled |
| 78 type, |
| 79 contexts)); |
| 80 RefreshMenu(model); |
| 81 } |
| 82 |
| 83 void ExtensionContextMenuModelTest::RefreshMenu( |
| 84 ExtensionContextMenuModel* model) { |
| 85 model->InitMenu(model->GetExtension()); |
| 86 } |
| 87 |
| 88 int ExtensionContextMenuModelTest::CountExtensionItems( |
| 89 ExtensionContextMenuModel* model) { |
| 90 return model->extension_items_count_; |
| 91 } |
| 92 |
| 93 namespace { |
| 94 |
25 // Tests that applicable menu items are disabled when a ManagementPolicy | 95 // Tests that applicable menu items are disabled when a ManagementPolicy |
26 // prohibits them. | 96 // prohibits them. |
27 TEST_F(ExtensionContextMenuModelTest, PolicyDisablesItems) { | 97 TEST_F(ExtensionContextMenuModelTest, PolicyDisablesItems) { |
28 InitializeEmptyExtensionService(); | 98 InitializeEmptyExtensionService(); |
29 // Build an extension to pass to the menu constructor. It needs an | 99 scoped_refptr<Extension> extension = BuildExtension(); |
30 // ExtensionAction. | |
31 scoped_refptr<Extension> extension = ExtensionBuilder() | |
32 .SetManifest(DictionaryBuilder() | |
33 .Set("name", "Page Action Extension") | |
34 .Set("version", "1") | |
35 .Set("manifest_version", 2) | |
36 .Set("page_action", DictionaryBuilder() | |
37 .Set("default_title", "Hello"))) | |
38 .Build(); | |
39 ASSERT_TRUE(extension.get()); | 100 ASSERT_TRUE(extension.get()); |
40 service_->AddExtension(extension.get()); | 101 service_->AddExtension(extension.get()); |
41 | 102 |
42 // Create a Browser for the ExtensionContextMenuModel to use. | 103 // Create a Browser for the ExtensionContextMenuModel to use. |
43 Browser::CreateParams params(profile_.get(), chrome::GetActiveDesktop()); | 104 Browser::CreateParams params(profile_.get(), chrome::GetActiveDesktop()); |
44 TestBrowserWindow test_window; | 105 TestBrowserWindow test_window; |
45 params.window = &test_window; | 106 params.window = &test_window; |
46 Browser browser(params); | 107 Browser browser(params); |
47 | 108 |
48 scoped_refptr<ExtensionContextMenuModel> menu( | 109 scoped_refptr<ExtensionContextMenuModel> menu( |
49 new ExtensionContextMenuModel(extension.get(), &browser, NULL)); | 110 new ExtensionContextMenuModel(extension.get(), &browser)); |
50 | 111 |
51 extensions::ExtensionSystem* system = | 112 extensions::ExtensionSystem* system = |
52 extensions::ExtensionSystem::Get(profile_.get()); | 113 extensions::ExtensionSystem::Get(profile_.get()); |
53 system->management_policy()->UnregisterAllProviders(); | 114 system->management_policy()->UnregisterAllProviders(); |
54 | 115 |
55 // Actions should be enabled. | 116 // Actions should be enabled. |
56 ASSERT_TRUE(menu->IsCommandIdEnabled(ExtensionContextMenuModel::UNINSTALL)); | 117 ASSERT_TRUE(menu->IsCommandIdEnabled(ExtensionContextMenuModel::UNINSTALL)); |
57 | 118 |
58 extensions::TestManagementPolicyProvider policy_provider( | 119 extensions::TestManagementPolicyProvider policy_provider( |
59 extensions::TestManagementPolicyProvider::PROHIBIT_MODIFY_STATUS); | 120 extensions::TestManagementPolicyProvider::PROHIBIT_MODIFY_STATUS); |
60 system->management_policy()->RegisterProvider(&policy_provider); | 121 system->management_policy()->RegisterProvider(&policy_provider); |
61 | 122 |
62 // Now the actions are disabled. | 123 // Now the actions are disabled. |
63 ASSERT_FALSE(menu->IsCommandIdEnabled(ExtensionContextMenuModel::UNINSTALL)); | 124 ASSERT_FALSE(menu->IsCommandIdEnabled(ExtensionContextMenuModel::UNINSTALL)); |
64 | 125 |
65 // Don't leave |policy_provider| dangling. | 126 // Don't leave |policy_provider| dangling. |
66 system->management_policy()->UnregisterAllProviders(); | 127 system->management_policy()->UnregisterAllProviders(); |
67 } | 128 } |
68 | 129 |
| 130 TEST_F(ExtensionContextMenuModelTest, ExtensionItemTest) { |
| 131 InitializeEmptyExtensionService(); |
| 132 scoped_refptr<Extension> extension = BuildExtension(); |
| 133 ASSERT_TRUE(extension.get()); |
| 134 service_->AddExtension(extension.get()); |
| 135 |
| 136 // Create a Browser for the ExtensionContextMenuModel to use. |
| 137 Browser::CreateParams params(profile_.get(), chrome::GetActiveDesktop()); |
| 138 TestBrowserWindow test_window; |
| 139 params.window = &test_window; |
| 140 Browser browser(params); |
| 141 |
| 142 // Create a MenuManager for adding context items. |
| 143 MenuManager* manager = static_cast<MenuManager*>( |
| 144 (MenuManagerFactory::GetInstance()->SetTestingFactoryAndUse( |
| 145 profile_.get(), |
| 146 &MenuManagerFactory::BuildServiceInstanceForTesting))); |
| 147 ASSERT_TRUE(manager); |
| 148 |
| 149 scoped_refptr<ExtensionContextMenuModel> menu( |
| 150 new ExtensionContextMenuModel(extension.get(), &browser)); |
| 151 |
| 152 // There should be no extension items yet. |
| 153 EXPECT_EQ(0, CountExtensionItems(menu)); |
| 154 |
| 155 // Add a browser action menu item for |extension| to |manager|. |
| 156 AddContextItemAndRefreshModel( |
| 157 manager, extension.get(), MenuItem::BROWSER_ACTION, menu); |
| 158 |
| 159 // Since |extension| has a page action, the browser action menu item should |
| 160 // not be present. |
| 161 EXPECT_EQ(0, CountExtensionItems(menu)); |
| 162 |
| 163 // Add a page action menu item and reset the context menu. |
| 164 AddContextItemAndRefreshModel( |
| 165 manager, extension.get(), MenuItem::PAGE_ACTION, menu); |
| 166 |
| 167 // The page action item should be present because |extension| has a page |
| 168 // action. |
| 169 EXPECT_EQ(1, CountExtensionItems(menu)); |
| 170 |
| 171 // Create more page action items to test top level menu item limitations. |
| 172 for (int i = 0; i < api::context_menus::ACTION_MENU_TOP_LEVEL_LIMIT; ++i) |
| 173 AddContextItemAndRefreshModel( |
| 174 manager, extension.get(), MenuItem::PAGE_ACTION, menu); |
| 175 |
| 176 // The menu should only have a limited number of extension items, since they |
| 177 // are all top level items, and we limit the number of top level extension |
| 178 // items. |
| 179 EXPECT_EQ(api::context_menus::ACTION_MENU_TOP_LEVEL_LIMIT, |
| 180 CountExtensionItems(menu)); |
| 181 |
| 182 AddContextItemAndRefreshModel( |
| 183 manager, extension.get(), MenuItem::PAGE_ACTION, menu); |
| 184 |
| 185 // Adding another top level item should not increase the count. |
| 186 EXPECT_EQ(api::context_menus::ACTION_MENU_TOP_LEVEL_LIMIT, |
| 187 CountExtensionItems(menu)); |
| 188 } |
| 189 |
69 } // namespace | 190 } // namespace |
70 } // namespace extensions | 191 } // namespace extensions |
OLD | NEW |