Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Side by Side Diff: chrome/browser/extensions/api/context_menus/context_menus_api_helpers.cc

Issue 359493005: Extend contextMenus API to support browser/page actions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Webview checks Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/extensions/api/context_menus/context_menus_api_helpers. h" 5 #include "chrome/browser/extensions/api/context_menus/context_menus_api_helpers. h"
6 6
7 #include "base/strings/string_number_conversions.h" 7 #include "base/strings/string_number_conversions.h"
8 8
9 namespace extensions { 9 namespace extensions {
10 namespace context_menus_api_helpers { 10 namespace context_menus_api_helpers {
11 11
12 const char kCannotFindItemError[] = "Cannot find menu item with id *"; 12 const char kCannotFindItemError[] = "Cannot find menu item with id *";
13 const char kCheckedError[] = 13 const char kCheckedError[] =
14 "Only items with type \"radio\" or \"checkbox\" can be checked"; 14 "Only items with type \"radio\" or \"checkbox\" can be checked";
15 const char kDuplicateIDError[] = 15 const char kDuplicateIDError[] =
16 "Cannot create item with duplicate id *"; 16 "Cannot create item with duplicate id *";
17 const char kGeneratedIdKey[] = "generatedId"; 17 const char kGeneratedIdKey[] = "generatedId";
18 const char kLauncherNotAllowedError[] = 18 const char kLauncherNotAllowedError[] =
19 "Only packaged apps are allowed to use 'launcher' context"; 19 "Only packaged apps are allowed to use 'launcher' context";
20 const char kActionNotAllowedError[] =
21 "Only packaged apps are allowed to use action contexts";
Yoyo Zhou 2014/07/24 00:17:57 Only extensions are allowed...
gpdavis 2014/07/24 00:23:32 Done.
20 const char kOnclickDisallowedError[] = "Extensions using event pages cannot " 22 const char kOnclickDisallowedError[] = "Extensions using event pages cannot "
21 "pass an onclick parameter to chrome.contextMenus.create. Instead, use " 23 "pass an onclick parameter to chrome.contextMenus.create. Instead, use "
22 "the chrome.contextMenus.onClicked event."; 24 "the chrome.contextMenus.onClicked event.";
23 const char kParentsMustBeNormalError[] = 25 const char kParentsMustBeNormalError[] =
24 "Parent items must have type \"normal\""; 26 "Parent items must have type \"normal\"";
25 const char kTitleNeededError[] = 27 const char kTitleNeededError[] =
26 "All menu items except for separators must have a title"; 28 "All menu items except for separators must have a title";
27 29
28 30
29 std::string GetIDString(const MenuItem::Id& id) { 31 std::string GetIDString(const MenuItem::Id& id) {
(...skipping 14 matching lines...) Expand all
44 } 46 }
45 if (parent->type() != MenuItem::NORMAL) { 47 if (parent->type() != MenuItem::NORMAL) {
46 *error = kParentsMustBeNormalError; 48 *error = kParentsMustBeNormalError;
47 return NULL; 49 return NULL;
48 } 50 }
49 return parent; 51 return parent;
50 } 52 }
51 53
52 } // namespace context_menus_api_helpers 54 } // namespace context_menus_api_helpers
53 } // namespace extensions 55 } // namespace extensions
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698