Issue 359413007: Improve error reporting for duplicate object template properties.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 359413007: Improve error reporting for duplicate object template properties. (Closed)

Created:
6 years, 5 months ago by Toon Verwaest

Modified:
6 years, 5 months ago

Reviewers:
Yang

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

Improve error reporting for duplicate object template properties. BUG= R=yangguo@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=22112

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+53 lines, -6 lines)			Patch
M	src/apinatives.js	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/messages.js	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	src/runtime.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	src/runtime.cc	View		1 chunk	+46 lines, -2 lines	0 comments	Download
A +	test/mjsunit/runtime-gen/addpropertyfortemplate.js	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	tools/generate-runtime-tests.py	View	1	2 chunks	+3 lines, -2 lines	0 comments	Download

Total messages: 3 (0 generated)

Yang

On 2014/07/01 09:54:11, Toon Verwaest wrote: > PTAL LGTM. AddProperty and AddPropertyForTemplate seem to have ...

6 years, 5 months ago (2014-07-01 09:57:16 UTC) #2

Toon Verwaest

6 years, 5 months ago (2014-07-01 10:00:35 UTC) #3

Message was sent while issue was closed.

Committed patchset #3 manually as r22112 (tree was closed).