sdk/lib/_internal/compiler/implementation/dart_backend/dart_tree_printer.dart - Issue 359413006: Fix handling of type literals.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/compiler/implementation/dart_backend/dart_tree_printer.dart

Issue 359413006: Fix handling of type literals. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Split visitTypeReferenceSend Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « sdk/lib/_internal/compiler/implementation/dart_backend/dart_printer.dart ('k') | sdk/lib/_internal/compiler/implementation/dart_backend/placeholder_collector.dart » ('j') | sdk/lib/_internal/compiler/implementation/ir/ir_builder.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sdk/lib/_internal/compiler/implementation/dart_backend/dart_tree_printer.dart

diff --git a/sdk/lib/_internal/compiler/implementation/dart_backend/dart_tree_printer.dart b/sdk/lib/_internal/compiler/implementation/dart_backend/dart_tree_printer.dart

index cc7b7e2f2787f7f336e32a97b7fcfe822e6e20c8..0d604cba6571dc13b3ea213bed572dafa6ac05b3 100644

--- a/sdk/lib/_internal/compiler/implementation/dart_backend/dart_tree_printer.dart

+++ b/sdk/lib/_internal/compiler/implementation/dart_backend/dart_tree_printer.dart

@@ -494,10 +494,14 @@ class TreePrinter {

makeList('.', exp.id.split('.').map(makeIdentifier)));

} else if (exp is LiteralType) {

precedence = TYPE_LITERAL;

+ elements.Element optionalElement = exp.type.element;

result = new tree.Send(

- makeStaticReceiver(exp.element),

+ optionalElement == null ? null : makeStaticReceiver(optionalElement),

makeIdentifier(exp.name));

- setElement(result, exp.element, exp);

+ treeElements.setType(result, exp.type);

+ if (optionalElement != null) { // dynamic does not have an element

+ setElement(result, optionalElement, exp);

+ }

} else if (exp is ReifyTypeVar) {

precedence = PRIMARY;

result = new tree.Send(