sdk/lib/_internal/compiler/implementation/inferrer/inferrer_visitor.dart - Issue 359413006: Fix handling of type literals.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/compiler/implementation/inferrer/inferrer_visitor.dart

Issue 359413006: Fix handling of type literals. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Updated cf. comments. Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « sdk/lib/_internal/compiler/implementation/dart_backend/placeholder_collector.dart ('k') | sdk/lib/_internal/compiler/implementation/ir/const_expression.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sdk/lib/_internal/compiler/implementation/inferrer/inferrer_visitor.dart

diff --git a/sdk/lib/_internal/compiler/implementation/inferrer/inferrer_visitor.dart b/sdk/lib/_internal/compiler/implementation/inferrer/inferrer_visitor.dart

index ce0388005c6a1abe3ab6e3044515ddf67e23a6ca..15cbf1eaac74853d0ae5662fc8e1bb29b60223f2 100644

--- a/sdk/lib/_internal/compiler/implementation/inferrer/inferrer_visitor.dart

+++ b/sdk/lib/_internal/compiler/implementation/inferrer/inferrer_visitor.dart

@@ -740,8 +740,13 @@ abstract class InferrerVisitor

return types.nonNullSubtype(compiler.symbolClass);

}

- T visitTypeReferenceSend(Send node) {

- return elements.isTypeLiteral(node) ? types.typeType : types.dynamicType;

+ T visitTypePrefixSend(Send node) {

+ // TODO(johnniwinther): Remove the need for handling this node.

+ return types.dynamicType;

+ }

+ T visitTypeLiteralSend(Send node) {

+ return types.typeType;

}

bool isThisOrSuper(Node node) => node.isThis() || node.isSuper();