sdk/lib/_internal/compiler/implementation/dart_backend/placeholder_collector.dart - Issue 359413006: Fix handling of type literals.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/compiler/implementation/dart_backend/placeholder_collector.dart

Issue 359413006: Fix handling of type literals. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Updated cf. comments. Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « sdk/lib/_internal/compiler/implementation/dart_backend/dart_tree_printer.dart ('k') | sdk/lib/_internal/compiler/implementation/inferrer/inferrer_visitor.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sdk/lib/_internal/compiler/implementation/dart_backend/placeholder_collector.dart

diff --git a/sdk/lib/_internal/compiler/implementation/dart_backend/placeholder_collector.dart b/sdk/lib/_internal/compiler/implementation/dart_backend/placeholder_collector.dart

index 901af2b5080f5443f7f2c738431e47c5abd94720..a15a5b659831569788e5e54483c0055c2c51ac56 100644

--- a/sdk/lib/_internal/compiler/implementation/dart_backend/placeholder_collector.dart

+++ b/sdk/lib/_internal/compiler/implementation/dart_backend/placeholder_collector.dart

@@ -141,9 +141,16 @@ class SendVisitor extends ResolvedVisitor {

collector.internalError(reason, node: node);

}

- visitTypeReferenceSend(Send node) {

+ visitTypePrefixSend(Send node) {

collector.makeElementPlaceholder(node.selector, elements[node]);

}

+ visitTypeLiteralSend(Send node) {

+ DartType type = elements.getTypeLiteralType(node);

+ if (!type.isDynamic) {

+ collector.makeElementPlaceholder(node.selector, type.element);

+ }

}

class PlaceholderCollector extends Visitor {