Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Side by Side Diff: sdk/lib/_internal/compiler/implementation/resolved_visitor.dart

Issue 359413006: Fix handling of type literals. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Split visitTypeReferenceSend Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 part of dart2js; 5 part of dart2js;
6 6
7 abstract class ResolvedVisitor<R> extends Visitor<R> { 7 abstract class ResolvedVisitor<R> extends Visitor<R> {
8 final Compiler compiler; 8 final Compiler compiler;
9 TreeElements elements; 9 TreeElements elements;
10 10
11 ResolvedVisitor(this.elements, this.compiler); 11 ResolvedVisitor(this.elements, this.compiler);
12 12
13 R visitSend(Send node) { 13 R visitSend(Send node) {
14 Element element = elements[node]; 14 Element element = elements[node];
15 if (node.isSuperCall) { 15 if (elements.isAssert(node)) {
16 return visitAssert(node);
17 } else if (elements.isTypeLiteral(node)) {
18 return visitTypeLiteralSend(node);
19 } else if (node.isSuperCall) {
16 return visitSuperSend(node); 20 return visitSuperSend(node);
17 } else if (node.isOperator) { 21 } else if (node.isOperator) {
18 return visitOperatorSend(node); 22 return visitOperatorSend(node);
19 } else if (node.isPropertyAccess) { 23 } else if (node.isPropertyAccess) {
20 if (!Elements.isUnresolved(element) && element.impliesType) { 24 if (!Elements.isUnresolved(element) && element.impliesType) {
21 // A reference to a class literal, typedef or type variable. 25 return visitTypePrefixSend(node);
22 return visitTypeReferenceSend(node);
23 } else { 26 } else {
24 return visitGetterSend(node); 27 return visitGetterSend(node);
25 } 28 }
26 } else if (element != null && Initializers.isConstructorRedirect(node)) { 29 } else if (element != null && Initializers.isConstructorRedirect(node)) {
27 return visitStaticSend(node); 30 return visitStaticSend(node);
28 } else if (Elements.isClosureSend(node, element)) { 31 } else if (Elements.isClosureSend(node, element)) {
29 return visitClosureSend(node); 32 return visitClosureSend(node);
30 } else if (elements.isAssert(node)) {
31 return visitAssert(node);
32 } else { 33 } else {
33 if (Elements.isUnresolved(element)) { 34 if (Elements.isUnresolved(element)) {
34 if (element == null) { 35 if (element == null) {
35 // Example: f() with 'f' unbound. 36 // Example: f() with 'f' unbound.
36 // This can only happen inside an instance method. 37 // This can only happen inside an instance method.
37 return visitDynamicSend(node); 38 return visitDynamicSend(node);
38 } else { 39 } else {
39 return visitStaticSend(node); 40 return visitStaticSend(node);
40 } 41 }
41 } else if (element.impliesType) {
42 // A reference to a class literal, typedef or type variable.
43 return visitTypeReferenceSend(node);
44 } else if (element.isInstanceMember) { 42 } else if (element.isInstanceMember) {
45 // Example: f() with 'f' bound to instance method. 43 // Example: f() with 'f' bound to instance method.
46 return visitDynamicSend(node); 44 return visitDynamicSend(node);
47 } else if (!element.isInstanceMember) { 45 } else if (!element.isInstanceMember) {
48 // Example: A.f() or f() with 'f' bound to a static function. 46 // Example: A.f() or f() with 'f' bound to a static function.
49 // Also includes new A() or new A.named() which is treated like a 47 // Also includes new A() or new A.named() which is treated like a
50 // static call to a factory. 48 // static call to a factory.
51 return visitStaticSend(node); 49 return visitStaticSend(node);
52 } else { 50 } else {
53 internalError("Cannot generate code for send", node: node); 51 internalError("Cannot generate code for send", node: node);
54 return null; 52 return null;
55 } 53 }
56 } 54 }
57 } 55 }
58 56
59 R visitSuperSend(Send node); 57 R visitSuperSend(Send node);
60 R visitOperatorSend(Send node); 58 R visitOperatorSend(Send node);
61 R visitGetterSend(Send node); 59 R visitGetterSend(Send node);
62 R visitClosureSend(Send node); 60 R visitClosureSend(Send node);
63 R visitDynamicSend(Send node); 61 R visitDynamicSend(Send node);
64 R visitStaticSend(Send node); 62 R visitStaticSend(Send node);
65 R visitTypeReferenceSend(Send node); 63
64 /// Visitor callback for a type literal.
65 R visitTypeLiteralSend(Send node);
66
67 /// Visitor callback for the class prefix of a static access, like `Foo` in
68 /// `Foo.staticField`.
69 // TODO(johnniwinther): Remove this when not needed by the dart backend.
70 R visitTypePrefixSend(Send node);
71
66 R visitAssert(Send node); 72 R visitAssert(Send node);
67 73
68 void internalError(String reason, {Node node}); 74 void internalError(String reason, {Node node});
69 75
70 R visitNode(Node node) { 76 R visitNode(Node node) {
71 internalError("Unhandled node", node: node); 77 internalError("Unhandled node", node: node);
72 return null; 78 return null;
73 } 79 }
74 } 80 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698