Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(791)

Issue 359413005: Revert of Disable speech synthesis API for content/ layer. (Closed)

Created:
6 years, 5 months ago by pfeldman
Modified:
6 years, 5 months ago
CC:
chromium-reviews, creis+watch_chromium.org, nasko+codewatch_chromium.org, jam, darin-cc_chromium.org, android-webview-reviews_chromium.org, jochen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Disable speech synthesis API for content/ layer. (https://codereview.chromium.org/355183002/) Reason for revert: This breaks layout tests that are enumerating window properties: PASS window.cached_scrollbars.visible is false -PASS window.cached_speechSynthesis.onvoiceschanged is null -PASS window.cached_speechSynthesis.paused is false -PASS window.cached_speechSynthesis.pending is false -PASS window.cached_speechSynthesis.speaking is false PASS window.cached_statusbar.visible is false http://test-results.appspot.com/dashboards/flakiness_dashboard.html#group=%40ToT%20Blink&tests=fast/dom/Window/property-access-on-cached-properties-after-frame-navigated.html,fast/dom/Window/property-access-on-cached-properties-after-frame-removed-and-gced.html,fast/dom/Window/property-access-on-cached-properties-after-frame-removed.html,fast/dom/Window/property-access-on-cached-window-after-frame-navigated.html,fast/dom/Window/property-access-on-cached-window-after-frame-removed-and-gced.html,fast/dom/Window/property-access-on-cached-window-after-frame-removed.html,fast/speechsynthesis/speech-synthesis-boundary-events.html,fast/speechsynthesis/speech-synthesis-cancel-twice.html,fast/speechsynthesis/speech-synthesis-cancel.html,fast/speechsynthesis/speech-synthesis-gc-utterance-crash.html,fast/speechsynthesis/speech-synthesis-pause-resume.html,fast/speechsynthesis/speech-synthesis-speak-invalid-argument-throws.html,fast/speechsynthesis/speech-synthesis-speak.html,fast/speechsynthesis/speech-synthesis-utterance-uses-voice.html,fast/speechsynthesis/speech-synthesis-voices-changed.html,fast/speechsynthesis/speech-synthesis-voices.html,virtual/stable/webexposed/global-constructors-listing.html,webexposed/global-constructors-listing.html Original issue's description: > Disable speech synthesis API for content/ layer. > > The Speech Synthesis API relies on an implementation in chrome/ > yet is a stable Web Platform feature so enabled in the content/ > layer. Flip the enable flag to a disable flag, and set it for > non-chrome content/ embedders. > > BUG=347045 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=280667 TBR=dmazzoni@chromium.org,brettw@chromium.org,benm@chromium.org NOTREECHECKS=true NOTRY=true BUG=347045 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=280749

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -14 lines) Patch
M android_webview/lib/main/aw_main_delegate.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 2 chunks +1 line, -1 line 0 comments Download
M content/child/runtime_features.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/public/common/content_switches.h View 1 chunk +1 line, -1 line 0 comments Download
M content/public/common/content_switches.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/shell/browser/shell_content_browser_client.cc View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
pfeldman
Created Revert of Disable speech synthesis API for content/ layer.
6 years, 5 months ago (2014-07-01 05:02:49 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pfeldman@chromium.org/359413005/1
6 years, 5 months ago (2014-07-01 05:03:26 UTC) #2
commit-bot: I haz the power
6 years, 5 months ago (2014-07-01 05:04:31 UTC) #3
Message was sent while issue was closed.
Change committed as 280749

Powered by Google App Engine
This is Rietveld 408576698