Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Unified Diff: chrome/renderer/extensions/safe_builtins_unittest.cc

Issue 359413004: Add support for using AMD modules from extensions modules. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: cross-context tests Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/extensions/safe_builtins_unittest.cc
diff --git a/chrome/renderer/extensions/safe_builtins_unittest.cc b/chrome/renderer/extensions/safe_builtins_unittest.cc
index acf8194b8b48b1700df4afaf60e49c87fafd4012..b0523609177e2ff245107edd12cb935b6b0e6972 100644
--- a/chrome/renderer/extensions/safe_builtins_unittest.cc
+++ b/chrome/renderer/extensions/safe_builtins_unittest.cc
@@ -11,56 +11,48 @@ class SafeBuiltinsUnittest : public ModuleSystemTest {
};
TEST_F(SafeBuiltinsUnittest, TestNotOriginalObject) {
- ModuleSystem::NativesEnabledScope natives_enabled_scope(
- context_->module_system());
- RegisterModule("test",
- "var assert = requireNative('assert');\n"
- "Array.foo = 10;\n"
- "assert.AssertTrue(!$Array.hasOwnProperty('foo'));\n"
- );
- context_->module_system()->Require("test");
+ ModuleSystem::NativesEnabledScope natives_enabled_scope(env_.module_system());
+ env_.RegisterModule("test",
+ "var assert = requireNative('assert');\n"
+ "Array.foo = 10;\n"
+ "assert.AssertTrue(!$Array.hasOwnProperty('foo'));\n");
+ env_.module_system()->Require("test");
}
TEST_F(SafeBuiltinsUnittest, TestSelf) {
- ModuleSystem::NativesEnabledScope natives_enabled_scope(
- context_->module_system());
- RegisterModule("test",
- "var assert = requireNative('assert');\n"
- "Array.foo = 10;\n"
- "assert.AssertTrue($Array.self.foo == 10);\n"
- "var arr = $Array.self(1);\n"
- "assert.AssertTrue(arr.length == 1);\n"
- "assert.AssertTrue(arr[0] === undefined);\n"
- );
- context_->module_system()->Require("test");
+ ModuleSystem::NativesEnabledScope natives_enabled_scope(env_.module_system());
+ env_.RegisterModule("test",
+ "var assert = requireNative('assert');\n"
+ "Array.foo = 10;\n"
+ "assert.AssertTrue($Array.self.foo == 10);\n"
+ "var arr = $Array.self(1);\n"
+ "assert.AssertTrue(arr.length == 1);\n"
+ "assert.AssertTrue(arr[0] === undefined);\n");
+ env_.module_system()->Require("test");
}
TEST_F(SafeBuiltinsUnittest, TestStaticFunction) {
- ModuleSystem::NativesEnabledScope natives_enabled_scope(
- context_->module_system());
- RegisterModule("test",
- "var assert = requireNative('assert');\n"
- "Object.keys = function() {throw new Error()};\n"
- "var obj = {a: 10};\n"
- "var keys = $Object.keys(obj);\n"
- "assert.AssertTrue(keys.length == 1);\n"
- "assert.AssertTrue(keys[0] == 'a');\n"
- );
- context_->module_system()->Require("test");
+ ModuleSystem::NativesEnabledScope natives_enabled_scope(env_.module_system());
+ env_.RegisterModule("test",
+ "var assert = requireNative('assert');\n"
+ "Object.keys = function() {throw new Error()};\n"
+ "var obj = {a: 10};\n"
+ "var keys = $Object.keys(obj);\n"
+ "assert.AssertTrue(keys.length == 1);\n"
+ "assert.AssertTrue(keys[0] == 'a');\n");
+ env_.module_system()->Require("test");
}
TEST_F(SafeBuiltinsUnittest, TestInstanceMethod) {
- ModuleSystem::NativesEnabledScope natives_enabled_scope(
- context_->module_system());
- RegisterModule("test",
- "var assert = requireNative('assert');\n"
- "Array.prototype.push = function() {throw new Error();}\n"
- "var arr = []\n"
- "$Array.push(arr, 1);\n"
- "assert.AssertTrue(arr.length == 1);\n"
- "assert.AssertTrue(arr[0] == 1);\n"
- );
- context_->module_system()->Require("test");
+ ModuleSystem::NativesEnabledScope natives_enabled_scope(env_.module_system());
+ env_.RegisterModule("test",
+ "var assert = requireNative('assert');\n"
+ "Array.prototype.push = function() {throw new Error();}\n"
+ "var arr = []\n"
+ "$Array.push(arr, 1);\n"
+ "assert.AssertTrue(arr.length == 1);\n"
+ "assert.AssertTrue(arr[0] == 1);\n");
+ env_.module_system()->Require("test");
}
// NOTE: JSON is already tested in ExtensionApiTest.Messaging, via

Powered by Google App Engine
This is Rietveld 408576698