Issue 35933003: Add documentation for GN's GYP generation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 35933003: Add documentation for GN's GYP generation. (Closed)

Created:
7 years, 2 months ago by brettw

Modified:
7 years, 1 month ago

Reviewers:
jamesr

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Add documentation for GN's GYP generation. BUG= R=jamesr@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=231148

Patch Set 4 : #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+62 lines, -2 lines)			Patch
	M	tools/gn/command_gyp.cc	View	1	1 chunk	+55 lines, -1 line	0 comments	Download
	M	tools/gn/variables.cc	View		1 chunk	+7 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

jamesr

lgtm https://codereview.chromium.org/35933003/diff/1/tools/gn/command_gyp.cc File tools/gn/command_gyp.cc (right): https://codereview.chromium.org/35933003/diff/1/tools/gn/command_gyp.cc#newcode290 tools/gn/command_gyp.cc:290: " ninja -C out/Debug gn\n" did you mean ...

7 years, 2 months ago (2013-10-22 21:54:48 UTC) #2

brettw

7 years, 1 month ago (2013-10-25 23:35:32 UTC) #3

Message was sent while issue was closed.

Committed patchset #4 manually as r231148 (presubmit successful).

Expand Messages | Collapse Messages

Issue 35933003: Add documentation for GN's GYP generation. (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Messages