Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(500)

Unified Diff: Tools/GardeningServer/scripts/ui/results.js

Issue 359283003: Remove usages of jquery and add sugar.js from garden-o-matic. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: merge to ToT Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Tools/GardeningServer/scripts/ui/results.js
diff --git a/Tools/GardeningServer/scripts/ui/results.js b/Tools/GardeningServer/scripts/ui/results.js
index d617ae56b0dda96347a71af261c4e3a671760a46..d623b4519afeffbdc175d76f2fbca2ef72f79a3f 100644
--- a/Tools/GardeningServer/scripts/ui/results.js
+++ b/Tools/GardeningServer/scripts/ui/results.js
@@ -45,7 +45,7 @@ ui.results.ResultsGrid = base.extends('div', {
resultsURLsByTypeAndKind[resultType][results.resultKind(url)] = url;
});
- $.each(resultsURLsByTypeAndKind, function(resultType, resultsURLsByKind) {
+ Object.keys(resultsURLsByTypeAndKind, function(resultType, resultsURLsByKind) {
if (results.kUnknownKind in resultsURLsByKind) {
// This is something like "crash" that isn't a comparison.
var result = document.createElement('ct-test-output');
@@ -89,11 +89,13 @@ ui.results.ResultsDetails = base.extends('div', {
var resultsGrid = new ui.results.ResultsGrid();
resultsGrid.addResults(resultsURLs);
- $(this).empty().append(
+ this.innerHTML = ''
+ this.appendChild(
new ui.actions.List([
new ui.actions.Previous(),
new ui.actions.Next()
- ])).append(resultsGrid);
+ ]))
+ this.appendChild(resultsGrid);
}.bind(this));
},
});
@@ -178,8 +180,7 @@ ui.results.TestSelector = base.extends('div', {
var cancelResize = function(event) { this._is_resizing = false; }.bind(this);
this.addEventListener('mouseup', cancelResize);
- // FIXME: Use addEventListener once WebKit adds support for mouseleave/mouseenter.
- $(window).bind('mouseleave', cancelResize);
+ document.body.addEventListener('mouseleave', cancelResize);
this.addEventListener('mousemove', function(event) {
if (!this._is_resizing)
@@ -269,7 +270,8 @@ ui.results.BuilderSelector = base.extends('div', {
var builderHash = base.underscoredBuilderName(builderName);
var link = document.createElement('a');
- $(link).attr('href', "#" + builderHash).text(ui.displayNameForBuilder(builderName));
+ link.href = "#" + builderHash;
+ link.textContent = ui.displayNameForBuilder(builderName);
tabStrip.appendChild(document.createElement('li')).appendChild(link);
var content = this._delegate.contentForTestAndBuilder(testName, builderName);
@@ -327,7 +329,7 @@ ui.results.View = base.extends('div', {
},
setResultsByTest: function(resultsByTest)
{
- $(this).empty();
+ this.innerHTML = '';
this._resultsByTest = resultsByTest;
this._testSelector = new ui.results.TestSelector(this, resultsByTest);
this.appendChild(this._testSelector);
« no previous file with comments | « Tools/GardeningServer/scripts/ui/notifications_unittests.js ('k') | Tools/GardeningServer/scripts/ui/results_unittests.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698