Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(235)

Issue 359253002: Remove bogus ASSERT in EventHandler::handleGestureEvent (Closed)

Created:
6 years, 5 months ago by Rick Byers
Modified:
6 years, 5 months ago
Reviewers:
Zeeshan Qureshi
CC:
blink-reviews, blink-reviews-events_chromium.org, dglazkov+blink, eae+blinkwatch, sof
Project:
blink
Visibility:
Public.

Description

Remove bogus ASSERT in EventHandler::handleGestureEvent I wrote this in r177164 thinking just that I wanted to verify the hit test traversed all iframe boundaries, but of course there are other widgets that aren't iframes (eg. plugins). I tried changing the ASSERT to verify explicitly that the target element is not an HTMLIFrameElement, but this doesn't work either because touch adjustment may adjust the target to be over an iframe element without necessarily hit-testing down into the iframe. This seems like we might want to change this to hit-test down through the frame after adjusting to it, but the behavior has been like this for a long time and we haven't seen an issue. So just remove the ASSERT completely. I don't think there's anything meaningful to verify here. TBRing to get the bots green ASAP and since the fix is trivial. TBR=zeeshanq BUG=390032 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177176

Patch Set 1 #

Patch Set 2 : Fix release build #

Patch Set 3 : Remove assert completely #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M Source/core/page/EventHandler.cpp View 1 2 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Rick Byers
The CQ bit was checked by rbyers@chromium.org
6 years, 5 months ago (2014-06-30 00:18:29 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rbyers@chromium.org/359253002/40001
6 years, 5 months ago (2014-06-30 00:20:14 UTC) #2
commit-bot: I haz the power
Change committed as 177176
6 years, 5 months ago (2014-06-30 00:55:13 UTC) #3
Zeeshan Qureshi
6 years, 5 months ago (2014-07-09 19:33:44 UTC) #4
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698