Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(364)

Issue 359173002: Make Map.set() and Set.add() chainable (Closed)

Created:
6 years, 5 months ago by caitp (gmail)
Modified:
6 years, 5 months ago
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -7 lines) Patch
M src/runtime.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M test/mjsunit/es6/weak_collections.js View 2 chunks +2 lines, -2 lines 0 comments Download
M test/mjsunit/harmony/collections.js View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
caitp (gmail)
Just re-opening this against bleeding_edge
6 years, 5 months ago (2014-06-28 23:54:47 UTC) #1
arv (Not doing code reviews)
LGTM Andreas, Caitlin has signed the CLA so this should be good to merge.
6 years, 5 months ago (2014-06-30 18:23:05 UTC) #2
caitp (gmail)
I think it's merge-able, but there's 3 failing tests in the intl suite that look ...
6 years, 5 months ago (2014-06-30 18:32:29 UTC) #3
arv (Not doing code reviews)
On 2014/06/30 at 18:32:29, caitpotter88 wrote: > I think it's merge-able, but there's 3 failing ...
6 years, 5 months ago (2014-06-30 18:43:11 UTC) #4
caitp (gmail)
It looks like the layout bot failures aren't unique to this CL, so unless someone ...
6 years, 5 months ago (2014-07-01 00:45:11 UTC) #5
rossberg
lgtm
6 years, 5 months ago (2014-07-01 09:46:25 UTC) #6
rossberg
6 years, 5 months ago (2014-07-01 09:49:43 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 manually as r22111 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698