Issue 358923002: Move ENABLE_MEDIA_CAPTURE to a runtime flag

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 358923002: Move ENABLE_MEDIA_CAPTURE to a runtime flag (Closed)

Created:
6 years, 6 months ago by lgombos

Modified:
6 years, 5 months ago

Reviewers:
Inactive, abarth-chromium

CC:
arv+blink, blink-reviews, blink-reviews-html_chromium.org, Inactive, dglazkov+blink, kinuko+fileapi, nhiroki, tzik, watchdog-blink-watchlist_google.com

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Project:
blink

Visibility:
Public.

More Reviews

Description

Move ENABLE_MEDIA_CAPTURE to a runtime flag The effort needs 3 steps: 1. Create the runtime flag interface in blink; 2. Enable the flag for Android from chromium even it does not do anything in blink; 3. Replace compile time guard with runtime flag in blink and remove the build time flag This is the third step. BUG=388093 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177262

Patch Set 1 #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+5 lines, -20 lines)			Patch
M	Source/build/features.gypi	View	1 chunk	+1 line, -6 lines	0 comments	Download
M	Source/config.gni	View	1 chunk	+1 line, -6 lines	0 comments	Download
M	Source/core/html/HTMLInputElement.idl	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/html/forms/FileInputType.cpp	View	1 chunk	+1 line, -3 lines	0 comments	Download
M	Source/platform/FileChooser.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	Source/web/ChromeClientImpl.cpp	View	1 chunk	+1 line, -2 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/l.gombos@samsung.com/358923002/1

6 years, 5 months ago (2014-07-01 02:06:57 UTC) #4

Message was sent while issue was closed.

Change committed as 177262

Expand Messages | Collapse Messages