build/common.gypi - Issue 358863002: Add gyp machinery to build with packed ARM relative relocations.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/common.gypi

Issue 358863002: Add gyp machinery to build with packed ARM relative relocations. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Update for review feedback (for realz this time!) Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: build/common.gypi

diff --git a/build/common.gypi b/build/common.gypi

index 0db92c8962d4d4dde243bcba85457064634be384..815dcb4b181b92c9305a4e509bf8b20e03499b6b 100644

--- a/build/common.gypi

+++ b/build/common.gypi

@@ -1703,6 +1703,9 @@

'android_stlport_libs_dir': '<(android_stlport_root)/libs/<(android_app_abi)',

'host_os%': '<(host_os)',

+ # Location of the "objcopy" binary, used by both gyp and scripts.

+ 'android_objcopy%' : '<!(/bin/echo -n <(android_toolchain)/*-objcopy)',

# Location of the "strip" binary, used by both gyp and scripts.

'android_strip%' : '<!(/bin/echo -n <(android_toolchain)/*-strip)',

« build/android/pack_arm_relocations.gypi ('K') | « build/android/pack_arm_relocations.gypi ('k') | build/java_apk.gypi » ('j') | build/java_apk.gypi » ('J')