Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 358773002: X87: The IC exposes a register definition. (Closed)

Created:
6 years, 6 months ago by chunyang.dai
Modified:
6 years, 6 months ago
Reviewers:
Weiliang, mvstanton
CC:
v8-dev, danno
Base URL:
https://github.com/v8/v8.git@master
Project:
v8
Visibility:
Public.

Description

X87: The IC exposes a register definition. port r22011 original commit message: Centralize a register definition in an IC that provides: 1) symbolic names for the register (like, edx == receiver) 2) defines ordering when passed on the stack Code that implements or uses the IC should use this definition instead of "knowing" what the registers are. Or at least have the definition to validate it's assumptions. As a side effect of avoiding runtime static initializers (enforced by tools/check-static-initializers.sh, neat), I gave ownership of the registers array to CodeStubInterfaceDescriptor. This prompted a cleanup of that struct BUG=

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+130 lines, -170 lines) Patch
M src/x87/code-stubs-x87.cc View 7 chunks +110 lines, -167 lines 0 comments Download
M src/x87/deoptimizer-x87.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/x87/ic-x87.cc View 1 chunk +13 lines, -0 lines 0 comments Download
M src/x87/stub-cache-x87.cc View 1 chunk +6 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
chunyang.dai
weiliang, please review this porting patch. thanks
6 years, 6 months ago (2014-06-26 05:14:18 UTC) #1
Weiliang
lgtm
6 years, 6 months ago (2014-06-26 05:42:03 UTC) #2
Weiliang
6 years, 6 months ago (2014-06-26 05:44:05 UTC) #3
Committed as r22028

Powered by Google App Engine
This is Rietveld 408576698