Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(166)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 358743002: Mojo: Remove InterfaceProvider. (Closed)

Created:
6 years, 5 months ago by Sam McNally
Modified:
6 years, 5 months ago
CC:
chromium-reviews, creis+watch_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, nasko+codewatch_chromium.org, jam, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin-cc_chromium.org, piman+watch_chromium.org, darin (slow to review), ben+mojo_chromium.org, chrome-apps-syd-reviews_chromium.org, DaveMoore
Visibility:
Public.

Description

Mojo: Remove InterfaceProvider. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=280569

Patch Set 1 : #

Total comments: 2

Patch Set 2 : address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -96 lines) Patch
M content/app/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/frame_host/render_frame_host_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/child/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M content/common/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M content/common/mojo/service_registry_impl.h View 3 chunks +7 lines, -8 lines 0 comments Download
M content/common/mojo/service_registry_impl.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M content/common/render_frame_setup.mojom View 1 chunk +2 lines, -2 lines 0 comments Download
M content/content_app.gypi View 1 chunk +1 line, -1 line 0 comments Download
M content/content_browser.gypi View 1 chunk +1 line, -1 line 0 comments Download
M content/content_child.gypi View 1 chunk +1 line, -1 line 0 comments Download
M content/content_common.gypi View 1 chunk +1 line, -1 line 0 comments Download
M content/content_common_mojo_bindings.gypi View 2 chunks +2 lines, -2 lines 0 comments Download
M content/content_gpu.gypi View 1 chunk +1 line, -1 line 0 comments Download
M content/content_plugin.gypi View 1 chunk +1 line, -1 line 0 comments Download
M content/content_ppapi_plugin.gypi View 1 chunk +1 line, -1 line 0 comments Download
M content/content_renderer.gypi View 1 chunk +1 line, -1 line 0 comments Download
M content/content_utility.gypi View 1 chunk +1 line, -1 line 0 comments Download
M content/content_worker.gypi View 1 chunk +1 line, -1 line 0 comments Download
M content/gpu/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M content/plugin/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M content/ppapi_plugin/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M content/public/common/service_registry.h View 1 2 chunks +8 lines, -7 lines 0 comments Download
M content/renderer/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/render_thread_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/web_ui_mojo.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/utility/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M content/worker/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M mojo/mojo_public.gypi View 1 chunk +0 lines, -15 lines 0 comments Download
D mojo/public/interfaces/interface_provider/BUILD.gn View 1 chunk +0 lines, -11 lines 0 comments Download
D mojo/public/interfaces/interface_provider/interface_provider.mojom View 1 chunk +0 lines, -12 lines 0 comments Download
D mojo/public/interfaces/shell/BUILD.gn View 1 chunk +0 lines, -11 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Sam McNally
6 years, 5 months ago (2014-06-26 01:50:41 UTC) #1
raymes
lg https://codereview.chromium.org/358743002/diff/50001/content/public/common/service_registry.h File content/public/common/service_registry.h (right): https://codereview.chromium.org/358743002/diff/50001/content/public/common/service_registry.h#newcode52 content/public/common/service_registry.h:52: // Connect to an interface provided by the ...
6 years, 5 months ago (2014-06-26 01:56:05 UTC) #2
Sam McNally
https://codereview.chromium.org/358743002/diff/50001/content/public/common/service_registry.h File content/public/common/service_registry.h (right): https://codereview.chromium.org/358743002/diff/50001/content/public/common/service_registry.h#newcode52 content/public/common/service_registry.h:52: // Connect to an interface provided by the remote ...
6 years, 5 months ago (2014-06-26 02:41:14 UTC) #3
darin (slow to review)
LGTM!
6 years, 5 months ago (2014-06-28 21:12:34 UTC) #4
Sam McNally
The CQ bit was checked by sammc@chromium.org
6 years, 5 months ago (2014-06-29 23:20:18 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sammc@chromium.org/358743002/50002
6 years, 5 months ago (2014-06-29 23:21:07 UTC) #6
commit-bot: I haz the power
6 years, 5 months ago (2014-06-30 06:48:58 UTC) #7
Message was sent while issue was closed. 
Change committed as 280569

Powered by Google App Engine
This is Rietveld 408576698