chrome/browser/resources/hangouts_services/manifest.json - Issue 35873003: Bundle Hangouts Services extension with Chrome

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/resources/hangouts_services/manifest.json

Issue 35873003: Bundle Hangouts Services extension with Chrome (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 {

	2 "name": "Hangouts Services",

	3 "version": "1.0",

	4 "manifest_version": 2,

	5 "icons": {

	6 "128": "icon_128.png"

	7 },

	8 "externally_connectable": {

	9 "matches": ["://.google.com/hangouts*"]
	meacer 2013/10/23 17:09:17 Should this be /hangouts/* rather than /hangouts* Should this be /hangouts/* rather than /hangouts* ? Also, can we restrict this to https? In which cases is http used? vrk (LEFT CHROMIUM) 2013/10/23 19:10:02 Yes, I think so. I'll double-check to make sure. Show quoted text On 2013/10/23 17:09:17, Mustafa Emre Acer wrote: > Should this be /hangouts/* rather than /hangouts* ? Yes, I think so. I'll double-check to make sure. Show quoted text > Also, can we restrict this to https? In which cases is http used? We run local test instances of Hangouts over http. If it's important to restrict this to https, we could do it -- it would just make testing local changes a bit inconvenient from the Hangouts-side. Let me know.
	10 },

	11 "background": {

	12 "scripts": ["thunk.js"],

	13 "persistent": false

	14 },

	15 "permissions": [

	16 "desktopCapture",

	17 "system.cpu",

	18 "webrtcAudioPrivate",

	19 "webrtcLoggingPrivate"

	20 ]

	21 }

OLD	NEW