src/arm/ic-arm.cc - Issue 3587002: Backport r5553 "Do not invoke indexed interceptor getters for negative indice...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/arm/ic-arm.cc

Issue 3587002: Backport r5553 "Do not invoke indexed interceptor getters for negative indice... (Closed) Base URL: http://v8.googlecode.com/svn/branches/2.1/

Patch Set: Created 10 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/arm/ic-arm.cc

===================================================================

--- src/arm/ic-arm.cc (revision 5553)

+++ src/arm/ic-arm.cc (working copy)

@@ -1004,8 +1004,9 @@

// Check that the receiver isn't a smi.

__ BranchOnSmi(r1, &slow);

- // Check that the key is a smi.

- __ BranchOnNotSmi(r0, &slow);

+ // Check that the key is an array index, that is Uint32.

+ __ tst(r0, Operand(kSmiTagMask | kSmiSignMask));

+ __ b(ne, &slow);

// Get the map of the receiver.

__ ldr(r2, FieldMemOperand(r1, HeapObject::kMapOffset));

« no previous file with comments | « no previous file | src/globals.h » ('j') | no next file with comments »