Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1963)

Side by Side Diff: src/x64/ic-x64.cc

Issue 3587002: Backport r5553 "Do not invoke indexed interceptor getters for negative indice... (Closed) Base URL: http://v8.googlecode.com/svn/branches/2.1/
Patch Set: Created 10 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/version.cc ('k') | test/cctest/test-api.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2010 the V8 project authors. All rights reserved. 1 // Copyright 2010 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 665 matching lines...) Expand 10 before | Expand all | Expand 10 after
676 // ----------------------------------- 676 // -----------------------------------
677 Label slow; 677 Label slow;
678 678
679 // Load key and receiver. 679 // Load key and receiver.
680 __ movq(rax, Operand(rsp, kPointerSize)); 680 __ movq(rax, Operand(rsp, kPointerSize));
681 __ movq(rcx, Operand(rsp, 2 * kPointerSize)); 681 __ movq(rcx, Operand(rsp, 2 * kPointerSize));
682 682
683 // Check that the receiver isn't a smi. 683 // Check that the receiver isn't a smi.
684 __ JumpIfSmi(rcx, &slow); 684 __ JumpIfSmi(rcx, &slow);
685 685
686 // Check that the key is a smi. 686 // Check that the key is an array index, that is Uint32.
687 __ JumpIfNotSmi(rax, &slow); 687 __ JumpIfNotPositiveSmi(rax, &slow);
688 688
689 // Get the map of the receiver. 689 // Get the map of the receiver.
690 __ movq(rdx, FieldOperand(rcx, HeapObject::kMapOffset)); 690 __ movq(rdx, FieldOperand(rcx, HeapObject::kMapOffset));
691 691
692 // Check that it has indexed interceptor and access checks 692 // Check that it has indexed interceptor and access checks
693 // are not enabled for this object. 693 // are not enabled for this object.
694 __ movb(rdx, FieldOperand(rdx, Map::kBitFieldOffset)); 694 __ movb(rdx, FieldOperand(rdx, Map::kBitFieldOffset));
695 __ andb(rdx, Immediate(kSlowCaseBitFieldMask)); 695 __ andb(rdx, Immediate(kSlowCaseBitFieldMask));
696 __ cmpb(rdx, Immediate(1 << Map::kHasIndexedInterceptor)); 696 __ cmpb(rdx, Immediate(1 << Map::kHasIndexedInterceptor));
697 __ j(not_zero, &slow); 697 __ j(not_zero, &slow);
(...skipping 850 matching lines...) Expand 10 before | Expand all | Expand 10 after
1548 __ bind(&miss); 1548 __ bind(&miss);
1549 1549
1550 GenerateMiss(masm); 1550 GenerateMiss(masm);
1551 } 1551 }
1552 1552
1553 1553
1554 #undef __ 1554 #undef __
1555 1555
1556 1556
1557 } } // namespace v8::internal 1557 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/version.cc ('k') | test/cctest/test-api.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698