Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Side by Side Diff: src/arm/ic-arm.cc

Issue 3587002: Backport r5553 "Do not invoke indexed interceptor getters for negative indice... (Closed) Base URL: http://v8.googlecode.com/svn/branches/2.1/
Patch Set: Created 10 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | src/globals.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2006-2008 the V8 project authors. All rights reserved. 1 // Copyright 2006-2008 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 986 matching lines...) Expand 10 before | Expand all | Expand 10 after
997 // -- sp[4] : receiver 997 // -- sp[4] : receiver
998 // ----------------------------------- 998 // -----------------------------------
999 Label slow; 999 Label slow;
1000 1000
1001 // Get the key and receiver object from the stack. 1001 // Get the key and receiver object from the stack.
1002 __ ldm(ia, sp, r0.bit() | r1.bit()); 1002 __ ldm(ia, sp, r0.bit() | r1.bit());
1003 1003
1004 // Check that the receiver isn't a smi. 1004 // Check that the receiver isn't a smi.
1005 __ BranchOnSmi(r1, &slow); 1005 __ BranchOnSmi(r1, &slow);
1006 1006
1007 // Check that the key is a smi. 1007 // Check that the key is an array index, that is Uint32.
1008 __ BranchOnNotSmi(r0, &slow); 1008 __ tst(r0, Operand(kSmiTagMask | kSmiSignMask));
1009 __ b(ne, &slow);
1009 1010
1010 // Get the map of the receiver. 1011 // Get the map of the receiver.
1011 __ ldr(r2, FieldMemOperand(r1, HeapObject::kMapOffset)); 1012 __ ldr(r2, FieldMemOperand(r1, HeapObject::kMapOffset));
1012 1013
1013 // Check that it has indexed interceptor and access checks 1014 // Check that it has indexed interceptor and access checks
1014 // are not enabled for this object. 1015 // are not enabled for this object.
1015 __ ldrb(r3, FieldMemOperand(r2, Map::kBitFieldOffset)); 1016 __ ldrb(r3, FieldMemOperand(r2, Map::kBitFieldOffset));
1016 __ and_(r3, r3, Operand(kSlowCaseBitFieldMask)); 1017 __ and_(r3, r3, Operand(kSlowCaseBitFieldMask));
1017 __ cmp(r3, Operand(1 << Map::kHasIndexedInterceptor)); 1018 __ cmp(r3, Operand(1 << Map::kHasIndexedInterceptor));
1018 __ b(ne, &slow); 1019 __ b(ne, &slow);
(...skipping 643 matching lines...) Expand 10 before | Expand all | Expand 10 after
1662 __ bind(&miss); 1663 __ bind(&miss);
1663 1664
1664 GenerateMiss(masm); 1665 GenerateMiss(masm);
1665 } 1666 }
1666 1667
1667 1668
1668 #undef __ 1669 #undef __
1669 1670
1670 1671
1671 } } // namespace v8::internal 1672 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « no previous file | src/globals.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698