Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Side by Side Diff: src/x64/ic-x64.cc

Issue 3586002: Backport r5553 "Do not invoke indexed interceptor getters for negative indice... (Closed) Base URL: http://v8.googlecode.com/svn/branches/2.2/
Patch Set: Created 10 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/version.cc ('k') | test/cctest/test-api.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2010 the V8 project authors. All rights reserved. 1 // Copyright 2010 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 904 matching lines...) Expand 10 before | Expand all | Expand 10 after
915 // ----------- S t a t e ------------- 915 // ----------- S t a t e -------------
916 // -- rax : key 916 // -- rax : key
917 // -- rdx : receiver 917 // -- rdx : receiver
918 // -- rsp[0] : return address 918 // -- rsp[0] : return address
919 // ----------------------------------- 919 // -----------------------------------
920 Label slow; 920 Label slow;
921 921
922 // Check that the receiver isn't a smi. 922 // Check that the receiver isn't a smi.
923 __ JumpIfSmi(rdx, &slow); 923 __ JumpIfSmi(rdx, &slow);
924 924
925 // Check that the key is a smi. 925 // Check that the key is an array index, that is Uint32.
926 __ JumpIfNotSmi(rax, &slow); 926 __ JumpIfNotPositiveSmi(rax, &slow);
927 927
928 // Get the map of the receiver. 928 // Get the map of the receiver.
929 __ movq(rcx, FieldOperand(rdx, HeapObject::kMapOffset)); 929 __ movq(rcx, FieldOperand(rdx, HeapObject::kMapOffset));
930 930
931 // Check that it has indexed interceptor and access checks 931 // Check that it has indexed interceptor and access checks
932 // are not enabled for this object. 932 // are not enabled for this object.
933 __ movb(rcx, FieldOperand(rcx, Map::kBitFieldOffset)); 933 __ movb(rcx, FieldOperand(rcx, Map::kBitFieldOffset));
934 __ andb(rcx, Immediate(kSlowCaseBitFieldMask)); 934 __ andb(rcx, Immediate(kSlowCaseBitFieldMask));
935 __ cmpb(rcx, Immediate(1 << Map::kHasIndexedInterceptor)); 935 __ cmpb(rcx, Immediate(1 << Map::kHasIndexedInterceptor));
936 __ j(not_zero, &slow); 936 __ j(not_zero, &slow);
(...skipping 935 matching lines...) Expand 10 before | Expand all | Expand 10 after
1872 GenerateMiss(masm); 1872 GenerateMiss(masm);
1873 } 1873 }
1874 1874
1875 1875
1876 #undef __ 1876 #undef __
1877 1877
1878 1878
1879 } } // namespace v8::internal 1879 } } // namespace v8::internal
1880 1880
1881 #endif // V8_TARGET_ARCH_X64 1881 #endif // V8_TARGET_ARCH_X64
OLDNEW
« no previous file with comments | « src/version.cc ('k') | test/cctest/test-api.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698