Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(452)

Side by Side Diff: src/arm/ic-arm.cc

Issue 3586002: Backport r5553 "Do not invoke indexed interceptor getters for negative indice... (Closed) Base URL: http://v8.googlecode.com/svn/branches/2.2/
Patch Set: Created 10 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | src/ia32/ic-ia32.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2006-2008 the V8 project authors. All rights reserved. 1 // Copyright 2006-2008 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1548 matching lines...) Expand 10 before | Expand all | Expand 10 after
1559 // ---------- S t a t e -------------- 1559 // ---------- S t a t e --------------
1560 // -- lr : return address 1560 // -- lr : return address
1561 // -- r0 : key 1561 // -- r0 : key
1562 // -- r1 : receiver 1562 // -- r1 : receiver
1563 // ----------------------------------- 1563 // -----------------------------------
1564 Label slow; 1564 Label slow;
1565 1565
1566 // Check that the receiver isn't a smi. 1566 // Check that the receiver isn't a smi.
1567 __ BranchOnSmi(r1, &slow); 1567 __ BranchOnSmi(r1, &slow);
1568 1568
1569 // Check that the key is a smi. 1569 // Check that the key is an array index, that is Uint32.
1570 __ BranchOnNotSmi(r0, &slow); 1570 __ tst(r0, Operand(kSmiTagMask | kSmiSignMask));
1571 __ b(ne, &slow);
1571 1572
1572 // Get the map of the receiver. 1573 // Get the map of the receiver.
1573 __ ldr(r2, FieldMemOperand(r1, HeapObject::kMapOffset)); 1574 __ ldr(r2, FieldMemOperand(r1, HeapObject::kMapOffset));
1574 1575
1575 // Check that it has indexed interceptor and access checks 1576 // Check that it has indexed interceptor and access checks
1576 // are not enabled for this object. 1577 // are not enabled for this object.
1577 __ ldrb(r3, FieldMemOperand(r2, Map::kBitFieldOffset)); 1578 __ ldrb(r3, FieldMemOperand(r2, Map::kBitFieldOffset));
1578 __ and_(r3, r3, Operand(kSlowCaseBitFieldMask)); 1579 __ and_(r3, r3, Operand(kSlowCaseBitFieldMask));
1579 __ cmp(r3, Operand(1 << Map::kHasIndexedInterceptor)); 1580 __ cmp(r3, Operand(1 << Map::kHasIndexedInterceptor));
1580 __ b(ne, &slow); 1581 __ b(ne, &slow);
(...skipping 652 matching lines...) Expand 10 before | Expand all | Expand 10 after
2233 GenerateMiss(masm); 2234 GenerateMiss(masm);
2234 } 2235 }
2235 2236
2236 2237
2237 #undef __ 2238 #undef __
2238 2239
2239 2240
2240 } } // namespace v8::internal 2241 } } // namespace v8::internal
2241 2242
2242 #endif // V8_TARGET_ARCH_ARM 2243 #endif // V8_TARGET_ARCH_ARM
OLDNEW
« no previous file with comments | « no previous file | src/ia32/ic-ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698