Added text filtering to Overview Mode

ui/views/controls/textfield/textfield.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/views/controls/textfield/textfield.h"
 
 #include <string>
 
 #include "base/debug/trace_event.h"
 #include "grit/ui_strings.h"
@@ skipping 391 matching lines @@
   GetRenderText()->set_selection_color(GetSelectionTextColor());
   SchedulePaint();
 }
 
 void Textfield::UseDefaultSelectionTextColor() {
   use_default_selection_text_color_ = true;
   GetRenderText()->set_selection_color(GetSelectionTextColor());
   SchedulePaint();
 }
 
+void Textfield::SetShadows(const gfx::ShadowValues& shadows) {
+  shadows_ = shadows;
+  SchedulePaint();
+}
+
 SkColor Textfield::GetSelectionBackgroundColor() const {
   return use_default_selection_background_color_ ?
       GetNativeTheme()->GetSystemColor(
           ui::NativeTheme::kColorId_TextfieldSelectionBackgroundFocused) :
       selection_background_color_;
 }
 
 void Textfield::SetSelectionBackgroundColor(SkColor color) {
   selection_background_color_ = color;
   use_default_selection_background_color_ = false;
@@ skipping 172 matching lines @@
 
 #if defined(OS_LINUX) && !defined(OS_CHROMEOS)
     if (event.IsOnlyMiddleMouseButton()) {
       if (GetRenderText()->IsPointInSelection(event.location())) {
         OnBeforeUserAction();
         ClearSelection();
         ui::ScopedClipboardWriter(
             ui::Clipboard::GetForCurrentThread(),
             ui::CLIPBOARD_TYPE_SELECTION).WriteText(base::string16());
         OnAfterUserAction();
-      } else if(!read_only()) {
+      } else if (!read_only()) {
         PasteSelectionClipboard(event);
       }
     }
 #endif
   }
 
   return true;
 }
 
 bool Textfield::OnMouseDragged(const ui::MouseEvent& event) {
@@ skipping 25 matching lines @@
   drag_selection_timer_.Stop();
   // Cancel suspected drag initiations, the user was clicking in the selection.
   if (initiating_drag_)
     MoveCursorTo(event.location(), false);
   initiating_drag_ = false;
   UpdateSelectionClipboard();
   OnAfterUserAction();
 }
 
 bool Textfield::OnKeyPressed(const ui::KeyEvent& event) {
+  // Since HandleKeyEvent() might destroy |this|, get a weak pointer and verify
+  // it isn't null before proceeding.

[sadrul, 2014/07/02 17:44:04]

This change should be in a separate CL, with a corresponding test.

+  base::WeakPtr<Textfield> textfield(weak_ptr_factory_.GetWeakPtr());
   bool handled = controller_ && controller_->HandleKeyEvent(this, event);
 
+  if (!textfield)
+    return handled;
+
 #if defined(OS_LINUX) && !defined(OS_CHROMEOS)
   ui::TextEditKeyBindingsDelegateAuraLinux* delegate =
       ui::GetTextEditKeyBindingsDelegate();
   std::vector<ui::TextEditCommandAuraLinux> commands;
   if (!handled && delegate && delegate->MatchEvent(event, &commands)) {
     const bool rtl = GetTextDirection() == base::i18n::RIGHT_TO_LEFT;
     for (size_t i = 0; i < commands.size(); ++i) {
       const int command = GetViewsCommand(commands[i], rtl);
       if (IsCommandIdEnabled(command)) {
         ExecuteCommand(command);
@@ skipping 919 matching lines @@
   // Draw placeholder text if needed.
   gfx::RenderText* render_text = GetRenderText();
   if (text().empty() && !GetPlaceholderText().empty()) {
     canvas->DrawStringRect(GetPlaceholderText(), GetFontList(),
         placeholder_text_color(), render_text->display_rect());
   }
 
   // Draw the text, cursor, and selection.
   render_text->set_cursor_visible(cursor_visible_ && !drop_cursor_visible_ &&
                                   !HasSelection());
+  render_text->set_shadows(shadows_);
+
   render_text->Draw(canvas);
 
   // Draw the detached drop cursor that marks where the text will be dropped.
   if (drop_cursor_visible_)
     render_text->DrawCursor(canvas, drop_cursor_position_);
 
   canvas->Restore();
 }
 
 void Textfield::MoveCursorTo(const gfx::Point& point, bool select) {
@@ skipping 160 matching lines @@
       const size_t length = selection_clipboard_text.length();
       range = gfx::Range(range.start() + length, range.end() + length);
     }
     model_->MoveCursorTo(gfx::SelectionModel(range, affinity));
     UpdateAfterChange(true, true);
     OnAfterUserAction();
   }
 }
 
 }  // namespace views