Added text filtering to Overview Mode

ui/views/controls/textfield/textfield.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/views/controls/textfield/textfield.h"
 
 #include <string>
 
 #include "base/debug/trace_event.h"
 #include "grit/ui_strings.h"
@@ skipping 250 matching lines @@
       use_default_selection_background_color_(true),
       text_color_(SK_ColorBLACK),
       background_color_(SK_ColorWHITE),
       selection_text_color_(SK_ColorWHITE),
       selection_background_color_(SK_ColorBLUE),
       placeholder_text_color_(kDefaultPlaceholderTextColor),
       text_input_type_(ui::TEXT_INPUT_TYPE_TEXT),
       performing_user_action_(false),
       skip_input_method_cancel_composition_(false),
       cursor_visible_(false),
+      has_shadow_(false),
       drop_cursor_visible_(false),
       initiating_drag_(false),
       aggregated_clicks_(0),
       weak_ptr_factory_(this) {
   set_context_menu_controller(this);
   set_drag_controller(this);
   SetBorder(scoped_ptr<Border>(new FocusableBorder()));
   SetFocusable(true);
 
   if (ViewsDelegate::views_delegate) {
@@ skipping 143 matching lines @@
   SchedulePaint();
 }
 
 void Textfield::UseDefaultSelectionBackgroundColor() {
   use_default_selection_background_color_ = true;
   GetRenderText()->set_selection_background_focused_color(
       GetSelectionBackgroundColor());
   SchedulePaint();
 }
 
+void Textfield::DisplayShadow(bool display_shadow) {
+  has_shadow_ = display_shadow;
+  SchedulePaint();

[tdanderson, 2014/06/25 15:48:23]

It should be the responsibility of the caller to invoke SchedulePaint() if
needed; we should not be doing it inside a mutator.

[Nina, 2014/06/26 15:20:18]

Hmmm all the other setters call SchedulePaint(). If this is better, we might
have to change those to inlined functions and make sure their callers call
SchedulePaint(), right?

+}
+
 bool Textfield::GetCursorEnabled() const {
   return GetRenderText()->cursor_enabled();
 }
 
 void Textfield::SetCursorEnabled(bool enabled) {
   GetRenderText()->SetCursorEnabled(enabled);
 }
 
 const gfx::FontList& Textfield::GetFontList() const {
   return GetRenderText()->font_list();
@@ skipping 1137 matching lines @@
   // Draw placeholder text if needed.
   gfx::RenderText* render_text = GetRenderText();
   if (text().empty() && !GetPlaceholderText().empty()) {
     canvas->DrawStringRect(GetPlaceholderText(), GetFontList(),
         placeholder_text_color(), render_text->display_rect());
   }
 
   // Draw the text, cursor, and selection.
   render_text->set_cursor_visible(cursor_visible_ && !drop_cursor_visible_ &&
                                   !HasSelection());
+
+  if (has_shadow_) {
+    // Draw a basic shadow underneath the text.
+    gfx::ShadowValues shadows;
+    shadows.push_back(gfx::ShadowValue(gfx::Point(0, 1), 10, SK_ColorBLACK));

[tdanderson, 2014/06/25 15:48:23]

I wonder if it's worthwhile defining constants for these arguments (as well as
any other hard-coded values we have in the overview mode code such as 1 for
"unfiltered opacity" and 0.5 as "filtered opacity". Then all of the values
controlling the look and feel would be in one place.

It might also be worth making a helper to avoid repetition of the logic: active
? 1 : 0.5.

[Nina, 2014/06/26 15:20:18]

As we discussed off the patch, we might want to change this later.

+    render_text->set_shadows(shadows);
+  }
+
   render_text->Draw(canvas);
 
   // Draw the detached drop cursor that marks where the text will be dropped.
   if (drop_cursor_visible_)
     render_text->DrawCursor(canvas, drop_cursor_position_);
 
   canvas->Restore();
 }
 
 void Textfield::MoveCursorTo(const gfx::Point& point, bool select) {
@@ skipping 160 matching lines @@
       const size_t length = selection_clipboard_text.length();
       range = gfx::Range(range.start() + length, range.end() + length);
     }
     model_->MoveCursorTo(gfx::SelectionModel(range, affinity));
     UpdateAfterChange(true, true);
     OnAfterUserAction();
   }
 }
 
 }  // namespace views