Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1439)

Unified Diff: chrome/browser/back_forward_menu_model_unittest.cc

Issue 3585002: Revert 60963 - Merge 58701 - Relanding this:... (Closed) Base URL: svn://svn.chromium.org/chrome/branches/517/src/
Patch Set: Created 10 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/renderer_host/test/test_render_view_host.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/back_forward_menu_model_unittest.cc
===================================================================
--- chrome/browser/back_forward_menu_model_unittest.cc (revision 60964)
+++ chrome/browser/back_forward_menu_model_unittest.cc (working copy)
@@ -40,23 +40,27 @@
// will be pending after we ask to navigate there).
void NavigateToOffset(int offset) {
controller().GoToOffset(offset);
- contents()->CommitPendingNavigation();
+ const NavigationEntry* entry = controller().pending_entry();
+ rvh()->SendNavigate(entry->page_id(), entry->url());
}
// Same as NavigateToOffset but goes to an absolute index.
void NavigateToIndex(int index) {
controller().GoToIndex(index);
- contents()->CommitPendingNavigation();
+ const NavigationEntry* entry = controller().pending_entry();
+ rvh()->SendNavigate(entry->page_id(), entry->url());
}
// Goes back/forward and commits the load.
void GoBack() {
controller().GoBack();
- contents()->CommitPendingNavigation();
+ const NavigationEntry* entry = controller().pending_entry();
+ rvh()->SendNavigate(entry->page_id(), entry->url());
}
void GoForward() {
controller().GoForward();
- contents()->CommitPendingNavigation();
+ const NavigationEntry* entry = controller().pending_entry();
+ rvh()->SendNavigate(entry->page_id(), entry->url());
}
};
« no previous file with comments | « no previous file | chrome/browser/renderer_host/test/test_render_view_host.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698