Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Issue 358473006: Revert of Remove burst mode from VSyncMonitor. (Closed)

Created:
6 years, 6 months ago by Peter Beverloo
Modified:
6 years, 6 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Remove burst mode from VSyncMonitor. (https://codereview.chromium.org/346813002/) Reason for revert: Four of the introduced tests time out on Android. VSyncMonitorTest#testVSyncActivationFromIdleAllowJBVSync VSyncMonitorTest#testVSyncActivationFromIdleDisallowJBVSync VSyncMonitorTest#testVSyncPeriodAllowJBVSync VSyncMonitorTest#testVSyncPeriodDisallowJBVSync The log output can be seen here: http://build.chromium.org/p/chromium.linux/builders/Android%20Tests%20%28dbg%29/builds/21188/steps/contentshell_instrumentation_tests/logs/stdio This failure could be observed in the try-bot results as part of the patch. Please do not use NOTRY unless you're absolutely certain that the failures are unrelated. Original issue's description: > Remove burst mode from VSyncMonitor. > > Extra vsyncs after each rendering cause 1% more power consumption. > > NOTRY=true > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=279997 TBR=tedchoc@chromium.org,sievers@chromium.org,aruslan@chromium.org,brianderson@chromium.org,skyostil@google.com,skyostil@chromium.org,bulach@chromium.org,miguelg@chromium.org,yfriedman@chromium.org,newt@chromium.org,egor.starkov@samsung.com NOTREECHECKS=true NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=280012

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -2 lines) Patch
M AUTHORS View 1 chunk +0 lines, -1 line 0 comments Download
M content/public/android/javatests/src/org/chromium/content/browser/VSyncMonitorTest.java View 1 chunk +1 line, -1 line 0 comments Download
M ui/android/java/src/org/chromium/ui/VSyncMonitor.java View 6 chunks +13 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Peter Beverloo
Created Revert of Remove burst mode from VSyncMonitor.
6 years, 6 months ago (2014-06-26 15:22:08 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/peter@chromium.org/358473006/1
6 years, 6 months ago (2014-06-26 15:22:54 UTC) #2
commit-bot: I haz the power
6 years, 6 months ago (2014-06-26 15:24:26 UTC) #3
Message was sent while issue was closed.
Change committed as 280012

Powered by Google App Engine
This is Rietveld 408576698