Only create arguments-maps in the bootstrapper, remove now obsolete ValueType flag.

src/factory.cc

 // Copyright 2014 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/factory.h"
 
+#include "src/allocation-site-scopes.h"
 #include "src/conversions.h"
 #include "src/isolate-inl.h"
 #include "src/macro-assembler.h"
 
 namespace v8 {
 namespace internal {
 
 
 template<typename T>
 Handle<T> Factory::New(Handle<Map> map, AllocationSpace space) {
@@ skipping 2060 matching lines @@
   debug_info->set_code(*code);
   debug_info->set_break_points(*break_points);
 
   // Link debug info to function.
   shared->set_debug_info(*debug_info);
 
   return debug_info;
 }
 
 
-Handle<JSObject> Factory::NewArgumentsObject(Handle<Object> callee,
+Handle<JSObject> Factory::NewArgumentsObject(Handle<JSFunction> callee,
                                              int length) {
-  CALL_HEAP_FUNCTION(
-      isolate(),
-      isolate()->heap()->AllocateArgumentsObject(*callee, length), JSObject);
+  bool strict_mode_callee = callee->IsJSFunction() &&
+      Handle<JSFunction>::cast(callee)->shared()->strict_mode() == STRICT;

[Igor Sheludko, 2014/07/02 14:17:14]

I think you can now avoid IsJSFunction() and casting here.

+  Handle<Map> map = strict_mode_callee
+    ? isolate()->strict_arguments_map()
+    : isolate()->sloppy_arguments_map();
+
+  AllocationSiteUsageContext context(
+      isolate(), Handle<AllocationSite>(), false);
+  ASSERT(!isolate()->has_pending_exception());
+  Handle<JSObject> result = NewJSObjectFromMap(map);
+  Handle<Smi> value(Smi::FromInt(length), isolate());
+  JSReceiver::SetProperty(
+      result, length_string(), value, NONE, STRICT).Assert();
+  if (!strict_mode_callee) {
+    JSReceiver::SetProperty(
+        result, callee_string(), callee, NONE, STRICT).Assert();
+  }
+  return result;
 }
 
 
 Handle<JSFunction> Factory::CreateApiFunction(
     Handle<FunctionTemplateInfo> obj,
     Handle<Object> prototype,
     ApiInstanceType instance_type) {
   Handle<Code> code = isolate()->builtins()->HandleApiCall();
   Handle<Code> construct_stub = isolate()->builtins()->JSConstructStubApi();
 
@@ skipping 263 matching lines @@
   return Handle<Object>::null();
 }
 
 
 Handle<Object> Factory::ToBoolean(bool value) {
   return value ? true_value() : false_value();
 }
 
 
 } }  // namespace v8::internal