Only create arguments-maps in the bootstrapper, remove now obsolete ValueType flag.

Only create arguments-maps in the bootstrapper, remove now obsolete ValueType flag.

R=ishell@chromium.org

Committed: https://code.google.com/p/v8/source/detail?r=22240

[Toon Verwaest, 2014-07-01 14:27:48]

PTAL

[Igor Sheludko, 2014-07-02 14:17:15]

lgtm with nits:

https://codereview.chromium.org/358363003/diff/60001/src/arm/code-stubs-arm.cc
File src/arm/code-stubs-arm.cc (right):

https://codereview.chromium.org/358363003/diff/60001/src/arm/code-stubs-arm.c...
src/arm/code-stubs-arm.cc:2034: // r4 = address of boilerplate object (tagged)
Outdated comment about r4.

https://codereview.chromium.org/358363003/diff/60001/src/arm64/code-stubs-arm...
File src/arm64/code-stubs-arm64.cc (right):

https://codereview.chromium.org/358363003/diff/60001/src/arm64/code-stubs-arm...
src/arm64/code-stubs-arm64.cc:2134: __ Str(args_offset,
FieldMemOperand(alloc_obj, JSObject::kMapOffset));
While you are here: args_offset and aliased_args_offset registers require better
names (for example, sloppy_args_map and aliased_args_map).

https://codereview.chromium.org/358363003/diff/60001/src/arm64/code-stubs-arm...
src/arm64/code-stubs-arm64.cc:2359: __ Str(args_offset,
FieldMemOperand(alloc_obj, JSObject::kMapOffset));
Same here: strict_args_map + outdated comment about x4

https://codereview.chromium.org/358363003/diff/60001/src/bootstrapper.cc
File src/bootstrapper.cc (right):

https://codereview.chromium.org/358363003/diff/60001/src/bootstrapper.cc#newc...
src/bootstrapper.cc:1173: #ifdef DEBUG
Probably we don't need #ifdef DEBUG anymore

https://codereview.chromium.org/358363003/diff/60001/src/bootstrapper.cc#newc...
src/bootstrapper.cc:1235: #ifdef DEBUG
Same here.

https://codereview.chromium.org/358363003/diff/60001/src/builtins.cc
File src/builtins.cc (right):

https://codereview.chromium.org/358363003/diff/60001/src/builtins.cc#newcode647
src/builtins.cc:647: sloppy_arguments_map();
While we are here: isolate()->sloppy_arguments_map()

https://codereview.chromium.org/358363003/diff/60001/src/factory.cc
File src/factory.cc (right):

https://codereview.chromium.org/358363003/diff/60001/src/factory.cc#newcode2091
src/factory.cc:2091: Handle<JSFunction>::cast(callee)->shared()->strict_mode()
== STRICT;
I think you can now avoid IsJSFunction() and casting here.

https://codereview.chromium.org/358363003/diff/60001/src/ia32/code-stubs-ia32.cc
File src/ia32/code-stubs-ia32.cc (right):

https://codereview.chromium.org/358363003/diff/60001/src/ia32/code-stubs-ia32...
src/ia32/code-stubs-ia32.cc:1076: // Get the arguments boilerplate from the
current native context into edi.
Outdated comment.

https://codereview.chromium.org/358363003/diff/60001/src/ia32/code-stubs-ia32...
src/ia32/code-stubs-ia32.cc:1095: // edi = address of boilerplate object
(tagged)
Same here.

https://codereview.chromium.org/358363003/diff/60001/src/ia32/code-stubs-ia32...
src/ia32/code-stubs-ia32.cc:1272: // Get the arguments boilerplate from the
current native context.
Same here

https://codereview.chromium.org/358363003/diff/60001/src/objects.cc
File src/objects.cc (right):

https://codereview.chromium.org/358363003/diff/60001/src/objects.cc#newcode5553
src/objects.cc:5553:
heap->isolate()->context()->native_context()->sloppy_arguments_map();
While you are here: isolate()->sloppy_arguments_map()

https://codereview.chromium.org/358363003/diff/60001/src/x64/code-stubs-x64.cc
File src/x64/code-stubs-x64.cc (right):

https://codereview.chromium.org/358363003/diff/60001/src/x64/code-stubs-x64.c...
src/x64/code-stubs-x64.cc:925: // Get the arguments boilerplate from the current
native context into rdi.
Outdated comment.

https://codereview.chromium.org/358363003/diff/60001/src/x64/code-stubs-x64.c...
src/x64/code-stubs-x64.cc:944: // rdi = address of boilerplate object (tagged)
Same here.

https://codereview.chromium.org/358363003/diff/60001/src/x64/code-stubs-x64.c...
src/x64/code-stubs-x64.cc:1143: // Get the arguments boilerplate from the
current native context.
Same here.

[Toon Verwaest, 2014-07-07 12:21:19]

Committed patchset #3 manually as r22240 (presubmit successful).