Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Unified Diff: src/base/logging.h

Issue 358363002: Move platform abstraction to base library (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: updates Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/base/logging.h
diff --git a/src/checks.h b/src/base/logging.h
similarity index 87%
copy from src/checks.h
copy to src/base/logging.h
index dd7a3955fb110e23a983b8d643df0265ce5d4dfe..de91077142bdfc08f1dce4ffa4c53b0dc6f757c3 100644
--- a/src/checks.h
+++ b/src/base/logging.h
@@ -2,8 +2,8 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#ifndef V8_CHECKS_H_
-#define V8_CHECKS_H_
+#ifndef V8_BASE_LOGGING_H_
+#define V8_BASE_LOGGING_H_
#include <string.h>
@@ -30,24 +30,6 @@ extern "C" void V8_Fatal(const char* file, int line, const char* format, ...);
#define UNREACHABLE() ((void) 0)
#endif
-// Simulator specific helpers.
-// We can't use USE_SIMULATOR here because it isn't defined yet.
-#if V8_TARGET_ARCH_ARM64 && !V8_HOST_ARCH_ARM64
- // TODO(all): If possible automatically prepend an indicator like
- // UNIMPLEMENTED or LOCATION.
- #define ASM_UNIMPLEMENTED(message) \
- __ Debug(message, __LINE__, NO_PARAM)
- #define ASM_UNIMPLEMENTED_BREAK(message) \
- __ Debug(message, __LINE__, \
- FLAG_ignore_asm_unimplemented_break ? NO_PARAM : BREAK)
- #define ASM_LOCATION(message) \
- __ Debug("LOCATION: " message, __LINE__, NO_PARAM)
-#else
- #define ASM_UNIMPLEMENTED(message)
- #define ASM_UNIMPLEMENTED_BREAK(message)
- #define ASM_LOCATION(message)
-#endif
-
// The CHECK macro checks that the given condition is true; if not, it
// prints a message to stderr and aborts.
@@ -242,28 +224,14 @@ inline void CheckNonEqualsHelper(const char* file,
#define CHECK_LE(a, b) CHECK((a) <= (b))
-#ifdef DEBUG
-#ifndef OPTIMIZED_DEBUG
-#define ENABLE_SLOW_ASSERTS 1
-#endif
-#endif
-
namespace v8 {
-namespace internal {
-#ifdef ENABLE_SLOW_ASSERTS
-#define SLOW_ASSERT(condition) \
- CHECK(!v8::internal::FLAG_enable_slow_asserts || (condition))
-extern bool FLAG_enable_slow_asserts;
-#else
-#define SLOW_ASSERT(condition) ((void) 0)
-const bool FLAG_enable_slow_asserts = false;
-#endif
+namespace base {
// Exposed for making debugging easier (to see where your function is being
// called, just add a call to DumpBacktrace).
void DumpBacktrace();
-} } // namespace v8::internal
+} } // namespace v8::base
// The ASSERT macro is equivalent to CHECK except that it only
@@ -296,4 +264,4 @@ void DumpBacktrace();
#define EXTRA_CHECK(condition) ((void) 0)
#endif
-#endif // V8_CHECKS_H_
+#endif // V8_BASE_LOGGING_H_

Powered by Google App Engine
This is Rietveld 408576698