Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 358283002: Add a UseCounter for legacy fullscreen key event filtering (Closed)

Created:
6 years, 5 months ago by philipj_slow
Modified:
6 years, 5 months ago
Reviewers:
falken
CC:
blink-reviews, blink-reviews-events_chromium.org, dglazkov+blink, eae+blinkwatch
Project:
blink
Visibility:
Public.

Description

Add a UseCounter for legacy fullscreen key event filtering Mozilla have already dropped the flags argument to mozRequestFullScreen, which is where ALLOW_KEYBOARD_INPUT is specified. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177198

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M Source/core/frame/UseCounter.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/page/EventHandler.cpp View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
philipj_slow
PTAL
6 years, 5 months ago (2014-06-29 01:24:24 UTC) #1
falken
On 2014/06/29 01:24:24, philipj wrote: > PTAL lgtm
6 years, 5 months ago (2014-06-30 02:04:07 UTC) #2
philipj_slow
The CQ bit was checked by philipj@opera.com
6 years, 5 months ago (2014-06-30 08:28:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/358283002/1
6 years, 5 months ago (2014-06-30 08:29:28 UTC) #4
commit-bot: I haz the power
6 years, 5 months ago (2014-06-30 08:32:43 UTC) #5
Message was sent while issue was closed.
Change committed as 177198

Powered by Google App Engine
This is Rietveld 408576698