Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
358203002:
Make fetch help display all known recipes. (Closed)
|
Created:
6 years, 5 months ago by iannucci Modified:
6 years, 4 months ago CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, iannucci+depot_tools_chromium.org, ilevy-cc_chromium.org Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master Project:
tools Visibility:
Public. |
DescriptionMake fetch help display all known recipes.
R=agable@chromium.org
BUG=366884
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=287832
Patch Set 1 #Patch Set 2 : rebase #Messages
Total messages: 15 (0 generated)
PTALPING
lgtm
The CQ bit was checked by iannucci@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/iannucci@chromium.org/358203002/1
The CQ bit was unchecked by commit-bot@chromium.org
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an LGTM may have been provided, it was from a non-committer or a provisional committer, _not_ a full super star committer. See http://www.chromium.org/getting-involved/become-a-committer Note that this has nothing to do with OWNERS files.
On 2014/08/06 19:13:05, I haz the power (commit-bot) wrote: > No LGTM from a valid reviewer yet. Only full committers are accepted. > Even if an LGTM may have been provided, it was from a non-committer or > a provisional committer, _not_ a full super star committer. > See http://www.chromium.org/getting-involved/become-a-committer > Note that this has nothing to do with OWNERS files. lgtm
The CQ bit was checked by iannucci@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/iannucci@chromium.org/358203002/1
The CQ bit was unchecked by commit-bot@chromium.org
Failed to apply patch for depot_tools/fetch.py:
While running patch -p1 --forward --force --no-backup-if-mismatch;
patching file depot_tools/fetch.py
Hunk #2 FAILED at 196.
1 out of 2 hunks FAILED -- saving rejects to file depot_tools/fetch.py.rej
Patch: depot_tools/fetch.py
Index: fetch.py
diff --git depot_tools/fetch.py depot_tools/fetch.py
index
d3bcacd793195438a658cee1e03c7e83fbc70f93..f42d0d668f543505ac74bd5b6b7072598a7004d7
100755
--- a/depot_tools/fetch.py
+++ b/depot_tools/fetch.py
@@ -21,9 +21,10 @@ These parameters will be passed through to the recipe's main
method.
import json
import optparse
import os
+import pipes
import subprocess
import sys
-import pipes
+import textwrap
from distutils import spawn
@@ -195,19 +196,23 @@ def usage(msg=None):
if msg:
print 'Error:', msg
- print (
-"""
-usage: %s [options] <recipe> [--property=value [--property2=value2 ...]]
+ print textwrap.dedent("""\
+ usage: %s [options] <recipe> [--property=value [--property2=value2 ...]]
+
+ This script can be used to download the Chromium sources. See
+ http://www.chromium.org/developers/how-tos/get-the-code
+ for full usage instructions.
+
+ Valid options:
+ -h, --help, help Print this message.
+ --nohooks Don't run hooks after checkout.
+ -n, --dry-run Don't run commands, only print them.
-This script can be used to download the Chromium sources. See
-http://www.chromium.org/developers/how-tos/get-the-code
-for full usage instructions.
+ Valid recipes:""") % os.path.basename(sys.argv[0])
+ for fname in os.listdir(os.path.join(SCRIPT_PATH, 'recipes')):
+ if fname.endswith('.py'):
+ print ' ' + fname[:-3]
-Valid options:
- -h, --help, help Print this message.
- --nohooks Don't run hooks after checkout.
- -n, --dry-run Don't run commands, only print them.
-""" % os.path.basename(sys.argv[0]))
sys.exit(bool(msg))
The CQ bit was checked by iannucci@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/iannucci@chromium.org/358203002/20001
Message was sent while issue was closed.
Change committed as 287832 |
