Tools/GardeningServer/scripts/ui/results.js - Issue 358173003: Remove rebaseline logic from GOM

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Tools/GardeningServer/scripts/ui/results.js

Issue 358173003: Remove rebaseline logic from GOM (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Tools/GardeningServer/scripts/ui/notifications_unittests.js ('k') | Tools/GardeningServer/scripts/ui/results_unittests.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Tools/GardeningServer/scripts/ui/results.js

diff --git a/Tools/GardeningServer/scripts/ui/results.js b/Tools/GardeningServer/scripts/ui/results.js

index 5da3d4615dd01b280e2780046b4caa27ccd3539f..6c81ec2e1ee8e473db5657de1b30535f37d370e1 100644

--- a/Tools/GardeningServer/scripts/ui/results.js

+++ b/Tools/GardeningServer/scripts/ui/results.js

@@ -322,15 +322,7 @@ ui.results.View = base.extends('div', {

contentForTest: function(testName)

{

- var rebaselineAction;

- if (isAnyReftest(testName, this._resultsByTest))

- rebaselineAction = $('<div class="non-action-button">Reftests cannot be rebaselined. Email webkit-gardening@chromium.org if unsure how to fix this.</div>');

- else

- rebaselineAction = new ui.actions.List([new ui.actions.Rebaseline().makeDefault()]);

- $(rebaselineAction).addClass('rebaseline-action');

var builderSelector = new ui.results.BuilderSelector(this, testName, this._resultsByTest[testName]);

- $(builderSelector).append(rebaselineAction).append($('<br style="clear:both">'));

$(builderSelector).bind('tabsselect', function(event, ui) {

// We will probably have pre-fetched the tab already, but we need to make sure.

ui.panel.show();