Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(402)

Side by Side Diff: Tools/GardeningServer/scripts/ui/results.js

Issue 358173003: Remove rebaseline logic from GOM (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011 Google Inc. All rights reserved. 2 * Copyright (C) 2011 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 304 matching lines...) Expand 10 before | Expand all | Expand 10 after
315 }); 315 });
316 316
317 ui.results.View = base.extends('div', { 317 ui.results.View = base.extends('div', {
318 init: function(delegate) 318 init: function(delegate)
319 { 319 {
320 this.className = 'results-view'; 320 this.className = 'results-view';
321 this._delegate = delegate; 321 this._delegate = delegate;
322 }, 322 },
323 contentForTest: function(testName) 323 contentForTest: function(testName)
324 { 324 {
325 var rebaselineAction;
326 if (isAnyReftest(testName, this._resultsByTest))
327 rebaselineAction = $('<div class="non-action-button">Reftests cannot be rebaselined. Email webkit-gardening@chromium.org if unsure how to fix this.< /div>');
328 else
329 rebaselineAction = new ui.actions.List([new ui.actions.Rebaseline(). makeDefault()]);
330 $(rebaselineAction).addClass('rebaseline-action');
331
332 var builderSelector = new ui.results.BuilderSelector(this, testName, thi s._resultsByTest[testName]); 325 var builderSelector = new ui.results.BuilderSelector(this, testName, thi s._resultsByTest[testName]);
333 $(builderSelector).append(rebaselineAction).append($('<br style="clear:b oth">'));
334 $(builderSelector).bind('tabsselect', function(event, ui) { 326 $(builderSelector).bind('tabsselect', function(event, ui) {
335 // We will probably have pre-fetched the tab already, but we need to make sure. 327 // We will probably have pre-fetched the tab already, but we need to make sure.
336 ui.panel.show(); 328 ui.panel.show();
337 }); 329 });
338 return builderSelector; 330 return builderSelector;
339 }, 331 },
340 contentForTestAndBuilder: function(testName, builderName) 332 contentForTestAndBuilder: function(testName, builderName)
341 { 333 {
342 var failureInfo = results.failureInfoForTestAndBuilder(this._resultsByTe st, testName, builderName); 334 var failureInfo = results.failureInfoForTestAndBuilder(this._resultsByTe st, testName, builderName);
343 return new ui.results.ResultsDetails(this, failureInfo); 335 return new ui.results.ResultsDetails(this, failureInfo);
(...skipping 29 matching lines...) Expand all
373 { 365 {
374 this._testSelector.firstResult() 366 this._testSelector.firstResult()
375 }, 367 },
376 currentTestName: function() 368 currentTestName: function()
377 { 369 {
378 return this._testSelector.currentTestName() 370 return this._testSelector.currentTestName()
379 } 371 }
380 }); 372 });
381 373
382 })(); 374 })();
OLDNEW
« no previous file with comments | « Tools/GardeningServer/scripts/ui/notifications_unittests.js ('k') | Tools/GardeningServer/scripts/ui/results_unittests.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698