Remove rebaseline logic from GOM

Tools/GardeningServer/scripts/controllers.js

 /*
  * Copyright (C) 2011 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 11 matching lines @@
  * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF
  * THE POSSIBILITY OF SUCH DAMAGE.
  */
 
 var controllers = controllers || {};
 
 (function(){
 
 var kCheckoutUnavailableMessage = 'Failed! Garden-o-matic needs a local server to modify your working copy. Please run "webkit-patch garden-o-matic" start the local server.';
 
-// FIXME: Where should this function go?
-function rebaselineWithStatusUpdates(failureInfoList, resultsByTest)
-{
-    var statusView = new ui.StatusArea('Rebaseline');
-    var id = statusView.newId();
-
-    var failuresToRebaseline = [];
-    var testNamesLogged = [];
-    failureInfoList.forEach(function(failureInfo) {
-        if (isAnyReftest(failureInfo.testName, resultsByTest)) {
-            if (testNamesLogged.indexOf(failureInfo.testName) == -1) {
-                statusView.addMessage(id, failureInfo.testName + ' is a ref test, skipping');
-                testNamesLogged.push(failureInfo.testName);
-            }
-        } else {
-            failuresToRebaseline.push(failureInfo);
-            if (testNamesLogged.indexOf(failureInfo.testName) == -1) {
-                statusView.addMessage(id, 'Rebaselining ' + failureInfo.testName + '...');
-                testNamesLogged.push(failureInfo.testName);
-            }
-        }
-    });
-
-    if (failuresToRebaseline.length) {
-        // FIXME: checkout.rebaseline() accepts only 3 arguments, we pass 5.
-        checkout.rebaseline(failuresToRebaseline, function(response) {
-            try {
-                var json = JSON.parse(response);
-                if (!json.result_code) {
-                    statusView.addFinalMessage(id, 'Rebaseline done! Please commit locally and land with "git cl dcommit".');
-                } else {
-                    statusView.addMessage(id, 'Rebaseline failed (code=' + json.result_code + ')!');
-                    statusView.addFinalMessage(id, json.output);
-                }
-            } catch (e) {
-                statusView.addFinalMessage(id, 'Invalid response received: "' + response + '"');
-            }
-        }, function(failureInfo) {
-            statusView.addMessage(id, failureInfo.testName + ' on ' + ui.displayNameForBuilder(failureInfo.builderName));
-        }, function() {
-            statusView.addFinalMessage(id, kCheckoutUnavailableMessage);
-        }, function(failureInfo) {
-            statusView.addMessage(id, 'Skipping rebaseline for ' + failureInfo.testName + ' on ' + ui.displayNameForBuilder(failureInfo.builderName) + ' because we only rebaseline from release bots.');
-        });
-    } else {
-        statusView.addFinalMessage(id, 'No non-reftests left to rebaseline!')
-    }
-}
-
 // FIXME: This is duplicated from ui/results.js :(.
 function isAnyReftest(testName, resultsByTest)
 {
     return Object.keys(resultsByTest[testName]).map(function(builder) {
         return resultsByTest[testName][builder];
     }).some(function(resultNode) {
         return resultNode.reftest_type && resultNode.reftest_type.length;
     });
 }
 
@@ skipping 18 matching lines @@
     init: function(view, resultsByTest)
     {
         this._view = view;
         this._resultsByTest = resultsByTest;
         this._view.setResultsByTest(resultsByTest);
 
         this._view.firstResult();
 
         $(this._view).bind('next', this.onNext.bind(this));
         $(this._view).bind('previous', this.onPrevious.bind(this));
-        $(this._view).bind('rebaseline', this.onRebaseline.bind(this));
         $(this._view).bind('expectfailure', this.onUpdateExpectations.bind(this));
     },
     onNext: function()
     {
         this._view.nextResult();
     },
     onPrevious: function()
     {
         this._view.previousResult();
     },
     _failureInfoList: function()
     {
         var testName = this._view.currentTestName();
         return Object.keys(this._resultsByTest[testName]).map(function(builderName) {
             return results.failureInfoForTestAndBuilder(this._resultsByTest, testName, builderName);
         }.bind(this));
     },
-    onRebaseline: function()
-    {
-        rebaselineWithStatusUpdates(this._failureInfoList(), this._resultsByTest);
-        this._view.nextTest();
-    },
     onUpdateExpectations: function()
     {
         updateExpectationsWithStatusUpdates(this._failureInfoList());
     }
 });
 
 controllers.ExpectedFailures = base.extends(Object, {
     init: function(model, view, delegate)
     {
         this._model = model;
@@ skipping 44 matching lines @@
     update: function(failureAnalysis)
     {
         var key = this._keyFor(failureAnalysis);
         var failure = this._testFailures.get(key);
         if (!failure) {
             failure = this._createFailureView(failureAnalysis);
             this._view.add(failure);
             $(failure).bind('examine', function() {
                 this.onExamine(failure);
             }.bind(this));
-            $(failure).bind('rebaseline', function() {
-                this.onRebaseline(failure);
-            }.bind(this));
             $(failure).bind('expectfailure', function() {
                 this.onUpdateExpectations(failure);
             }.bind(this));
         }
         failure.addFailureAnalysis(failureAnalysis);
         this._testFailures.update(key, failure);
         return failure;
     },
     purge: function() {
         this._testFailures.purge(function(failure) {
@@ skipping 16 matching lines @@
                 return testNameList.indexOf(key) != -1;
             });
 
         var controller = new controllers.ResultsDetails(resultsView, failuresByTest);
         this._delegate.showResults(resultsView);
     },
     _toFailureInfoList: function(failures)
     {
         return base.flattenArray(failures.testNameList().map(model.unexpectedFailureInfoForTestName));
     },
-    onRebaseline: function(failures)
-    {
-        var testNameList = failures.testNameList();
-        var failuresByTest = base.filterDictionary(
-            this._resultsFilter(this._model.resultsByBuilder),
-            function(key) {
-                return testNameList.indexOf(key) != -1;
-            });
-
-        rebaselineWithStatusUpdates(this._toFailureInfoList(failures), failuresByTest);
-    },
     onUpdateExpectations: function(failures)
     {
         updateExpectationsWithStatusUpdates(this._toFailureInfoList(failures));
     }
 });
 
 controllers.UnexpectedFailures = base.extends(FailureStreamController, {
     _resultsFilter: results.unexpectedFailuresByTest,
 
     _impliedFirstFailingRevision: function(failureAnalysis)
@@ skipping 58 matching lines @@
             this._notification = new ui.notifications.BuildersFailing(this._message);
             this._view.add(this._notification);
         }
         // FIXME: We should provide regression ranges for the failing builders.
         // This doesn't seem to happen often enough to worry too much about that, however.
         this._notification.setFailingBuilders(failuresList);
     }
 });
 
 })();