Source/core/rendering/compositing/GraphicsLayerUpdater.cpp - Issue 358153003: Get rid of one-off paint invalidation code for paints-into-ancestor compositing state

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/compositing/GraphicsLayerUpdater.cpp

Issue 358153003: Get rid of one-off paint invalidation code for paints-into-ancestor compositing state (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Addressed comment from vollick@ Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/core/rendering/compositing/CompositedLayerMapping.cpp ('k') | Source/core/rendering/compositing/RenderLayerCompositor.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/rendering/compositing/GraphicsLayerUpdater.cpp

diff --git a/Source/core/rendering/compositing/GraphicsLayerUpdater.cpp b/Source/core/rendering/compositing/GraphicsLayerUpdater.cpp

index 9bbf3a2d3a8c57ef120b9e3e595aaf5830eb4e77..d1335b4f2eea514e37a495f3020d00ad72119a3b 100644

--- a/Source/core/rendering/compositing/GraphicsLayerUpdater.cpp

+++ b/Source/core/rendering/compositing/GraphicsLayerUpdater.cpp

@@ -92,8 +92,10 @@ void GraphicsLayerUpdater::updateRecursive(RenderLayer& layer, UpdateType update

const RenderLayer* compositingContainer = context.compositingContainer(layer);

ASSERT(compositingContainer == layer.ancestorCompositingLayer());

- if (mapping->updateRequiresOwnBackingStoreForAncestorReasons(compositingContainer))

+ if (mapping->updateRequiresOwnBackingStoreForAncestorReasons(compositingContainer)) {

+ layersNeedingPaintInvalidation.append(&layer);

updateType = ForceUpdate;

+ }

// Note carefully: here we assume that the compositing state of all descendants have been updated already,

// so it is legitimate to compute and cache the composited bounds for this layer.