Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(529)

Issue 358133002: Relaxing the stop contidtion to search for a previous continuation chain. (Closed)

Created:
6 years, 5 months ago by byoungyoung
Modified:
6 years, 5 months ago
Reviewers:
inferno
CC:
blink-reviews, blink-reviews-rendering, zoltan1, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, pdr., rune+blink
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Relaxing the stop condition to search for a previous continuation chain. containingBlockIgnoringAnonymous serves as a stop condition of tree visits (previousInPreOrder). Before the patch, containingBlockIgnoringAnonymous was not the root RenderObject of the previous continuation chain, and thus the previous continuation was not cleared properly. This patch relaxes the stop condition by using isAnonymous() instead of isAnonymousBlock() so that the tree search can skip all anonymous wrappers including RenderTableRow or RenderTableCell. BUG=389285 TEST=unminimizable test from clusterfuzz R=inferno@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177122

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M Source/core/rendering/RenderBlock.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
inferno
lgtm
6 years, 5 months ago (2014-06-27 16:06:57 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/byoungyoung@chromium.org/358133002/1
6 years, 5 months ago (2014-06-27 16:07:19 UTC) #2
commit-bot: I haz the power
6 years, 5 months ago (2014-06-27 17:10:29 UTC) #3
Message was sent while issue was closed.
Change committed as 177122

Powered by Google App Engine
This is Rietveld 408576698