Issue 3581002: Fixed several cromo problems.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3581002: Fixed several cromo problems. (Closed)

Created:
10 years, 2 months ago by Eric Shienbrood

Modified:
9 years, 7 months ago

Reviewers:
Elly Fong-Jones

CC:
chromium-os-reviews_chromium.org

Base URL:
ssh://git@gitrw.chromium.org:9222/cromo.git

Visibility:
Public.

Description

Fixed several cromo problems. - cromo would crash if it was interrupted with a SIGINT or SIGTERM because of confusion about the ownership of the MessageHandler object. - a typo in the Makefile kept the HexEsnToDecimal function from being exported as a dynamic symbol. - SIGINT wouldn't result in cromo exiting. BUG=none TEST=verified that all these problems went away and that cromo still functions normally Change-Id: I2b98ae40a936f483892947bf618074ed2b761234 Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=60a5d4f

Patch Set 1 #

Created: 10 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -5 lines)			Patch
	M	Makefile	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	main.cc	View		4 chunks	+3 lines, -4 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Elly Fong-Jones

10 years, 2 months ago (2010-09-29 18:33:20 UTC) #2

On 2010/09/29 18:07:01, Eric Shienbrood wrote:
> 

Awesome - I've had the MessageHandler one on my TODO list for a few days now.
LGTM!

Expand Messages | Collapse Messages