Issue 358033005: Drop early-outs for "no boxes" in SVGTextQuery entrypoints

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 358033005: Drop early-outs for "no boxes" in SVGTextQuery entrypoints (Closed)

Created:
6 years, 5 months ago by fs

Modified:
6 years, 5 months ago

Reviewers:
pdr.

CC:
blink-reviews, blink-reviews-rendering, zoltan1, eae+blinkwatch, leviw+renderwatch, kouhei+svg_chromium.org, fs, ed+blinkwatch_opera.com, krit, f(malita), gyuyoung.kim_webkit.org, jchaffraix+rendering, rwlbuis, Stephen Chennney, rune+blink

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

More Reviews

Description

Drop early-outs for "no boxes" in SVGTextQuery entrypoints All entrypoints in SVGTextQuery start with check if the text content element has any boxes. If it doesn't, a value representing "empty" is returned. In all cases this value is the same as the default value of the corresponding query-data. SVGTextQuery::executeQuery itself has no problems handling this case (and will return 'false' as expected.) Removing these early-outs means a few more cycles is needed in these "degenerate" cases, although that seems like a small (and hopefully reasonable) price to pay for less code (and duplication/exit-paths). Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177149