Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 358033003: Fix LayoutState for relatively positioned inlines (Closed)

Created:
6 years, 5 months ago by Julien - ping for review
Modified:
6 years, 5 months ago
CC:
blink-reviews, blink-reviews-rendering, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr., rune+blink, zoltan1
Project:
blink
Visibility:
Public.

Description

Fix LayoutState for relatively positioned inlines We forgot to push LayoutState for inlines which meant that we didn't invalidate correctly relatively positioned inlines as the offset was wrong. This was visible in fast/repaint/inline-relative-positioned.html where we invalidated at the wrong position (and ultimately for the wrong reasons). Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177154

Patch Set 1 #

Patch Set 2 : Fixed the test expectations #

Patch Set 3 : Added missing test. #

Patch Set 4 : Better test. #

Patch Set 5 : Fixed test to be cross-platform. #

Patch Set 6 : Damn Windows. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -4 lines) Patch
M LayoutTests/TestExpectations View 1 2 3 4 5 1 chunk +2 lines, -0 lines 0 comments Download
M LayoutTests/fast/repaint/inline-relative-positioned-expected.txt View 1 1 chunk +1 line, -2 lines 0 comments Download
A LayoutTests/fast/repaint/layoutstate-invalid-invalidation-inline-relative-positioned.html View 1 2 3 4 1 chunk +15 lines, -0 lines 0 comments Download
A + LayoutTests/fast/repaint/layoutstate-invalid-invalidation-inline-relative-positioned-expected.txt View 1 2 3 4 1 chunk +3 lines, -2 lines 0 comments Download
M Source/core/rendering/LayoutState.h View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/core/rendering/LayoutState.cpp View 1 chunk +27 lines, -0 lines 0 comments Download
M Source/core/rendering/RenderInline.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/rendering/RenderInline.cpp View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (0 generated)
Julien - ping for review
6 years, 5 months ago (2014-06-27 00:20:02 UTC) #1
leviw_travelin_and_unemployed
The code change LGTM, but can we get a test where you can actually see ...
6 years, 5 months ago (2014-06-27 17:21:15 UTC) #2
Julien - ping for review
On 2014/06/27 at 17:21:15, leviw wrote: > The code change LGTM, but can we get ...
6 years, 5 months ago (2014-06-27 18:12:07 UTC) #3
Julien - ping for review
The CQ bit was checked by jchaffraix@chromium.org
6 years, 5 months ago (2014-06-27 18:13:02 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jchaffraix@chromium.org/358033003/40001
6 years, 5 months ago (2014-06-27 18:14:11 UTC) #5
Julien - ping for review
The CQ bit was checked by jchaffraix@chromium.org
6 years, 5 months ago (2014-06-27 18:34:24 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jchaffraix@chromium.org/358033003/60001
6 years, 5 months ago (2014-06-27 18:34:36 UTC) #7
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: mac_blink_rel on tryserver.blink ...
6 years, 5 months ago (2014-06-27 19:52:12 UTC) #8
Julien - ping for review
The CQ bit was checked by jchaffraix@chromium.org
6 years, 5 months ago (2014-06-27 20:14:55 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jchaffraix@chromium.org/358033003/70001
6 years, 5 months ago (2014-06-27 20:15:36 UTC) #10
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...
6 years, 5 months ago (2014-06-27 21:16:54 UTC) #11
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-06-27 21:53:11 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/14181)
6 years, 5 months ago (2014-06-27 21:53:12 UTC) #13
Julien - ping for review
The CQ bit was checked by jchaffraix@chromium.org
6 years, 5 months ago (2014-06-27 22:21:23 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jchaffraix@chromium.org/358033003/90001
6 years, 5 months ago (2014-06-27 22:21:50 UTC) #15
commit-bot: I haz the power
6 years, 5 months ago (2014-06-27 23:50:00 UTC) #16
Message was sent while issue was closed.
Change committed as 177154

Powered by Google App Engine
This is Rietveld 408576698