Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(237)

Issue 35803004: Remove TreatNullAs=NullString for media interfaces (Closed)

Created:
7 years, 2 months ago by philipj_slow
Modified:
7 years, 2 months ago
CC:
blink-reviews, nessy, feature-media-reviews_chromium.org, dglazkov+blink, adamk+blink_chromium.org, vcarbune.chromium
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Remove TreatNullAs=NullString for media interfaces The spec doesn't have special null handling here: http://www.whatwg.org/specs/web-apps/current-work/multipage/the-video-element.html The updated test was run in Firefox Nightly (with media.webvtt.enabled), IE11 Release Preview and Opera 12.16 (Presto 2.12.388). Everything passes, with these exceptions: No other browser supports the mediaGroup property. The preload default value is "metadata" in IE11 and Presto, and "" in Firefox. The spec suggests "metadata". Bugs filed: https://code.google.com/p/chromium/issues/detail?id=310450 https://bugzilla.mozilla.org/show_bug.cgi?id=929890 BUG=310298 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=160318

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -21 lines) Patch
M LayoutTests/fast/dom/element-attribute-js-null.html View 7 chunks +18 lines, -9 lines 0 comments Download
M LayoutTests/fast/dom/element-attribute-js-null-expected.txt View 3 chunks +7 lines, -7 lines 0 comments Download
M Source/core/html/HTMLMediaElement.idl View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/html/HTMLSourceElement.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLTrackElement.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLVideoElement.idl View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
philipj_slow
Erik said in <http://code.google.com/p/chromium/issues/detail?id=304959#c9> that he'd rather have a mass removal, but I already had ...
7 years, 2 months ago (2013-10-22 21:54:59 UTC) #1
arv (Not doing code reviews)
LGTM
7 years, 2 months ago (2013-10-22 22:01:23 UTC) #2
haraken
LGTM, given the spec and the behavior of Firefox and IE. Needs an approval from ...
7 years, 2 months ago (2013-10-22 22:47:05 UTC) #3
Inactive
On 2013/10/22 21:54:59, philipj wrote: > Erik said in <http://code.google.com/p/chromium/issues/detail?id=304959#c9> that > he'd rather have ...
7 years, 2 months ago (2013-10-22 23:17:25 UTC) #4
Inactive
Lgtm but I think the cl description is a bit light. Optimally, it should explain ...
7 years, 2 months ago (2013-10-22 23:26:03 UTC) #5
philipj_slow
On 2013/10/22 23:17:25, Chris Dumez wrote: > On 2013/10/22 21:54:59, philipj wrote: > > Erik ...
7 years, 2 months ago (2013-10-23 06:18:16 UTC) #6
jochen (gone - plz use gerrit)
lgtm
7 years, 2 months ago (2013-10-23 07:01:26 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/35803004/1
7 years, 2 months ago (2013-10-23 07:03:59 UTC) #8
commit-bot: I haz the power
7 years, 2 months ago (2013-10-23 08:24:13 UTC) #9
Message was sent while issue was closed.
Change committed as 160318

Powered by Google App Engine
This is Rietveld 408576698