Additions to Activities to allow resource management

athena/activity/public/activity_view_model.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef ATHENA_ACTIVITY_PUBLIC_ACTIVITY_VIEW_MODEL_H_
 #define ATHENA_ACTIVITY_PUBLIC_ACTIVITY_VIEW_MODEL_H_
 
 #include "athena/athena_export.h"
 #include "base/strings/string16.h"
 
 typedef unsigned int SkColor;
 
+namespace gfx {
+class ImageSkia;
+}
+
 namespace views {
 class View;
 }
 
 namespace athena {
 
+// The view model for the representation of the activity.
 class ATHENA_EXPORT ActivityViewModel {
  public:
   virtual ~ActivityViewModel() {}
 
-  // Called after the view model is attaced to the widget/window tree.
+  // Called after the view model is attached to the widget/window tree.
   virtual void Init() = 0;
 
   // Returns a color most representative of this activity.
   virtual SkColor GetRepresentativeColor() = 0;
 
   // Returns a title for the activity.
   virtual base::string16 GetTitle() = 0;
 
-  // Returns the contents view.
+  // Returns the contents view which might be NULL if the activity is not
+  // loaded. Note that the caller should not hold on to the view since it can
+  // be deleted by the resource manager.
   virtual views::View* GetContentsView() = 0;
+
+  // This gets called before the Activity gets (partially) thrown out of memory
+  // to create a preview image of the activity. Note that even if this function
+  // gets called, |GetOverviewModeImage()| could still return an empty image.
+  virtual void CreateOverviewModeImage() = 0;

[oshima, 2014/07/11 18:02:59]

Since the actual behavior is undefined, how about "PrepareOverviewModeImage()" ?

[Mr4D (OOO till 08-26), 2014/07/11 22:38:08]

In the question of "Prepare" vs. "create" I would always pick "create" since
"prepare" suggests that you need to do another call to actually really do it. I
would prefer to keep the name...

+
+  // Returns an image which can be used to represent the activity in e.g. the
+  // overview mode. The returned image can have no size if either a view exists
+  // or the activity has not yet been loaded. In that case
+  // GetRepresentativeColor() should be used to clear the preview area.
+  // Note: We intentionally do not use a layer / view for this.
+  virtual gfx::ImageSkia GetOverviewModeImage() = 0;
 };
 
 }  // namespace athena
 
 #endif  // ATHENA_ACTIVITY_PUBLIC_ACTIVITY_VIEW_MODEL_H_