Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 357943002: Fixup for test (was missing a closing tag). (Closed)

Created:
6 years, 6 months ago by Erik Dahlström (inactive)
Modified:
6 years, 5 months ago
Reviewers:
f(malita), fs
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Fixup for test (was missing a closing tag). Add another test for empty (but rendered) paths. BUG=388676 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177059

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -1 line) Patch
M LayoutTests/fast/svg/getbbox.html View 3 chunks +11 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Erik Dahlström (inactive)
@fmalita: as promised (https://codereview.chromium.org/355813004/#msg9) I had a look at the updateObjectBoundingBox method, which only user ...
6 years, 6 months ago (2014-06-26 11:57:42 UTC) #1
f(malita)
lgtm
6 years, 6 months ago (2014-06-26 12:43:17 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ed@opera.com/357943002/1
6 years, 6 months ago (2014-06-26 12:44:13 UTC) #3
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...
6 years, 6 months ago (2014-06-26 13:47:41 UTC) #4
commit-bot: I haz the power
6 years, 5 months ago (2014-06-27 04:08:11 UTC) #5
Message was sent while issue was closed.
Change committed as 177059

Powered by Google App Engine
This is Rietveld 408576698