Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(222)

Issue 35783003: Revert 230227 "Implement app list folder management page UI, inc..." (Closed)

Created:
7 years, 2 months ago by Jeffrey Yasskin
Modified:
7 years, 2 months ago
Reviewers:
jennyz
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 230227 "Implement app list folder management page UI, inc..." It caused use-after-frees at http://build.chromium.org/p/chromium.memory.fyi/builders/Chromium%20OS%20%28valgrind%29%283%29/builds/29082/steps/memory%20test%3A%20ash_unittests/logs/stdio > Implement app list folder management page UI, including the following feature: > 1. Clicking on a folder item in the app list grid will open the app list folder management page to show the folder name and items in the folder. > 2. User can click on the back button on folder management page to navigate back to the app list page. > 3. User can change the app list folder name on folder management page. > > BUG=303224 > TBR=sky > > Review URL: https://codereview.chromium.org/27777002 TBR=jennyz@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=230256

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -713 lines) Patch
M trunk/src/ash/test/app_list_controller_test_api.h View 2 chunks +0 lines, -4 lines 0 comments Download
M trunk/src/ash/test/app_list_controller_test_api.cc View 2 chunks +0 lines, -10 lines 0 comments Download
M trunk/src/chrome/browser/ui/ash/launcher/chrome_launcher_controller_browsertest.cc View 3 chunks +2 lines, -5 lines 0 comments Download
M trunk/src/ui/app_list/app_list.gyp View 2 chunks +0 lines, -7 lines 0 comments Download
M trunk/src/ui/app_list/app_list_constants.h View 1 chunk +0 lines, -1 line 0 comments Download
M trunk/src/ui/app_list/app_list_constants.cc View 1 chunk +0 lines, -1 line 0 comments Download
M trunk/src/ui/app_list/app_list_folder_item.cc View 3 chunks +5 lines, -4 lines 0 comments Download
D trunk/src/ui/app_list/views/app_list_folder_view.h View 1 chunk +0 lines, -70 lines 0 comments Download
D trunk/src/ui/app_list/views/app_list_folder_view.cc View 1 chunk +0 lines, -94 lines 0 comments Download
M trunk/src/ui/app_list/views/app_list_main_view.h View 1 chunk +0 lines, -2 lines 0 comments Download
M trunk/src/ui/app_list/views/app_list_main_view.cc View 2 chunks +1 line, -6 lines 0 comments Download
M trunk/src/ui/app_list/views/app_list_view.h View 1 chunk +0 lines, -1 line 0 comments Download
D trunk/src/ui/app_list/views/apps_container_view.h View 1 chunk +0 lines, -66 lines 0 comments Download
D trunk/src/ui/app_list/views/apps_container_view.cc View 1 chunk +0 lines, -93 lines 0 comments Download
M trunk/src/ui/app_list/views/apps_grid_view.h View 3 chunks +3 lines, -4 lines 0 comments Download
M trunk/src/ui/app_list/views/apps_grid_view.cc View 7 chunks +22 lines, -27 lines 0 comments Download
M trunk/src/ui/app_list/views/apps_grid_view_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M trunk/src/ui/app_list/views/contents_view.h View 3 chunks +1 line, -6 lines 0 comments Download
M trunk/src/ui/app_list/views/contents_view.cc View 9 chunks +26 lines, -25 lines 0 comments Download
D trunk/src/ui/app_list/views/folder_header_view.h View 1 chunk +0 lines, -76 lines 0 comments Download
D trunk/src/ui/app_list/views/folder_header_view.cc View 1 chunk +0 lines, -179 lines 0 comments Download
D trunk/src/ui/app_list/views/folder_header_view_delegate.h View 1 chunk +0 lines, -27 lines 0 comments Download
M trunk/src/ui/base/strings/ui_strings.grd View 1 chunk +0 lines, -3 lines 0 comments Download
M trunk/src/ui/resources/ui_resources.grd View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Jeffrey Yasskin
7 years, 2 months ago (2013-10-23 00:01:28 UTC) #1
Jeffrey Yasskin
7 years, 2 months ago (2013-10-23 00:01:52 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r230256.

Powered by Google App Engine
This is Rietveld 408576698