Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(644)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 357793002: Remove SkBicubicImageFilter, and all related tests. (Closed)

Created:
6 years, 6 months ago by Stephen White
Modified:
6 years, 6 months ago
Reviewers:
bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Remove SkBicubicImageFilter, and all related tests. Now that we have SkResizeImageFilter, and the bicubic resizing is part of skia proper, there's no need for a specialized image filter. BUG=skia: Committed: https://skia.googlesource.com/skia/+/7bf106847304840526a3e722b5ff5ce7322a2826

Patch Set 1 #

Patch Set 2 : Remove all expected results for now-deleted GM #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -3101 lines) Patch
D bench/BicubicBench.cpp View 1 chunk +0 lines, -58 lines 0 comments Download
M expectations/gm/Test-Android-GalaxyNexus-SGX540-Arm7-Debug/expected-results.json View 1 2 chunks +1 line, -25 lines 0 comments Download
M expectations/gm/Test-Android-GalaxyNexus-SGX540-Arm7-Release/expected-results.json View 1 2 chunks +1 line, -25 lines 0 comments Download
M expectations/gm/Test-Android-IntelRhb-SGX544-x86-Debug/expected-results.json View 1 2 chunks +1 line, -37 lines 0 comments Download
M expectations/gm/Test-Android-IntelRhb-SGX544-x86-Release/expected-results.json View 1 2 chunks +1 line, -37 lines 0 comments Download
M expectations/gm/Test-Android-Logan-Nvidia-Arm7-Debug/expected-results.json View 1 2 chunks +1 line, -46 lines 0 comments Download
M expectations/gm/Test-Android-Logan-Nvidia-Arm7-Release/expected-results.json View 1 2 chunks +1 line, -46 lines 0 comments Download
M expectations/gm/Test-Android-Nexus10-MaliT604-Arm7-Debug/expected-results.json View 1 2 chunks +1 line, -43 lines 0 comments Download
M expectations/gm/Test-Android-Nexus10-MaliT604-Arm7-Release/expected-results.json View 1 2 chunks +1 line, -43 lines 0 comments Download
M expectations/gm/Test-Android-Nexus4-Adreno320-Arm7-Debug/expected-results.json View 1 2 chunks +1 line, -37 lines 0 comments Download
M expectations/gm/Test-Android-Nexus4-Adreno320-Arm7-Release/expected-results.json View 1 2 chunks +1 line, -37 lines 0 comments Download
M expectations/gm/Test-Android-Nexus7-Tegra3-Arm7-Debug/expected-results.json View 1 2 chunks +1 line, -34 lines 0 comments Download
M expectations/gm/Test-Android-Nexus7-Tegra3-Arm7-Release/expected-results.json View 1 2 chunks +1 line, -34 lines 0 comments Download
M expectations/gm/Test-Android-NexusS-SGX540-Arm7-Debug/expected-results.json View 1 2 chunks +1 line, -25 lines 0 comments Download
M expectations/gm/Test-Android-NexusS-SGX540-Arm7-Release/expected-results.json View 1 2 chunks +1 line, -25 lines 0 comments Download
M expectations/gm/Test-Android-RazrI-SGX540-x86-Debug/expected-results.json View 1 2 chunks +1 line, -49 lines 0 comments Download
M expectations/gm/Test-Android-RazrI-SGX540-x86-Release/expected-results.json View 1 2 chunks +1 line, -49 lines 0 comments Download
M expectations/gm/Test-Android-Xoom-Tegra2-Arm7-Debug/expected-results.json View 1 2 chunks +1 line, -34 lines 0 comments Download
M expectations/gm/Test-Android-Xoom-Tegra2-Arm7-Release/expected-results.json View 1 2 chunks +1 line, -34 lines 0 comments Download
M expectations/gm/Test-ChromeOS-Alex-GMA3150-x86-Debug/expected-results.json View 1 2 chunks +1 line, -19 lines 0 comments Download
M expectations/gm/Test-ChromeOS-Alex-GMA3150-x86-Release/expected-results.json View 1 2 chunks +1 line, -19 lines 0 comments Download
M expectations/gm/Test-ChromeOS-Daisy-MaliT604-Arm7-Debug/expected-results.json View 1 2 chunks +1 line, -25 lines 0 comments Download
M expectations/gm/Test-ChromeOS-Daisy-MaliT604-Arm7-Release/expected-results.json View 1 2 chunks +1 line, -25 lines 0 comments Download
M expectations/gm/Test-ChromeOS-Link-HD4000-x86_64-Debug/expected-results.json View 1 2 chunks +1 line, -25 lines 0 comments Download
M expectations/gm/Test-ChromeOS-Link-HD4000-x86_64-Release/expected-results.json View 1 2 chunks +1 line, -25 lines 0 comments Download
M expectations/gm/Test-Linux-Bare-NoGPU-Arm8_64-Debug/expected-results.json View 1 2 chunks +1 line, -25 lines 0 comments Download
M expectations/gm/Test-Mac10.6-MacMini4.1-GeForce320M-x86-Debug/expected-results.json View 1 2 chunks +1 line, -61 lines 0 comments Download
M expectations/gm/Test-Mac10.6-MacMini4.1-GeForce320M-x86-Release/expected-results.json View 1 2 chunks +1 line, -49 lines 0 comments Download
M expectations/gm/Test-Mac10.6-MacMini4.1-GeForce320M-x86_64-Debug/expected-results.json View 1 2 chunks +1 line, -61 lines 0 comments Download
M expectations/gm/Test-Mac10.6-MacMini4.1-GeForce320M-x86_64-Release/expected-results.json View 1 2 chunks +1 line, -49 lines 0 comments Download
M expectations/gm/Test-Mac10.7-MacMini4.1-GeForce320M-x86-Debug/expected-results.json View 1 2 chunks +1 line, -61 lines 0 comments Download
M expectations/gm/Test-Mac10.7-MacMini4.1-GeForce320M-x86-Release/expected-results.json View 1 2 chunks +1 line, -49 lines 0 comments Download
M expectations/gm/Test-Mac10.7-MacMini4.1-GeForce320M-x86_64-Debug/expected-results.json View 1 2 chunks +1 line, -61 lines 0 comments Download
M expectations/gm/Test-Mac10.7-MacMini4.1-GeForce320M-x86_64-Release/expected-results.json View 1 2 chunks +1 line, -49 lines 0 comments Download
M expectations/gm/Test-Mac10.8-MacMini4.1-GeForce320M-x86-Debug/expected-results.json View 1 2 chunks +1 line, -61 lines 0 comments Download
M expectations/gm/Test-Mac10.8-MacMini4.1-GeForce320M-x86-Release/expected-results.json View 1 2 chunks +1 line, -49 lines 0 comments Download
M expectations/gm/Test-Mac10.8-MacMini4.1-GeForce320M-x86_64-Debug/expected-results.json View 1 2 chunks +1 line, -61 lines 0 comments Download
M expectations/gm/Test-Mac10.8-MacMini4.1-GeForce320M-x86_64-Release/expected-results.json View 1 2 chunks +1 line, -58 lines 0 comments Download
M expectations/gm/Test-Ubuntu12-ShuttleA-GTX660-x86-Debug/expected-results.json View 1 2 chunks +1 line, -64 lines 0 comments Download
M expectations/gm/Test-Ubuntu12-ShuttleA-GTX660-x86-Release/expected-results.json View 1 2 chunks +1 line, -64 lines 0 comments Download
M expectations/gm/Test-Ubuntu12-ShuttleA-GTX660-x86_64-Debug/expected-results.json View 1 2 chunks +1 line, -70 lines 0 comments Download
M expectations/gm/Test-Ubuntu12-ShuttleA-GTX660-x86_64-Release/expected-results.json View 1 2 chunks +1 line, -70 lines 0 comments Download
M expectations/gm/Test-Ubuntu13.10-ShuttleA-NoGPU-x86_64-Debug/expected-results.json View 1 2 chunks +1 line, -37 lines 0 comments Download
M expectations/gm/Test-Win7-ShuttleA-HD2000-x86-Debug-ANGLE/expected-results.json View 1 2 chunks +1 line, -61 lines 0 comments Download
M expectations/gm/Test-Win7-ShuttleA-HD2000-x86-Debug-DirectWrite/expected-results.json View 1 2 chunks +1 line, -43 lines 0 comments Download
M expectations/gm/Test-Win7-ShuttleA-HD2000-x86-Debug/expected-results.json View 1 2 chunks +1 line, -43 lines 0 comments Download
M expectations/gm/Test-Win7-ShuttleA-HD2000-x86-Release-ANGLE/expected-results.json View 1 2 chunks +1 line, -61 lines 0 comments Download
M expectations/gm/Test-Win7-ShuttleA-HD2000-x86-Release-DirectWrite/expected-results.json View 1 2 chunks +1 line, -43 lines 0 comments Download
M expectations/gm/Test-Win7-ShuttleA-HD2000-x86-Release/expected-results.json View 1 2 chunks +1 line, -43 lines 0 comments Download
M expectations/gm/Test-Win7-ShuttleA-HD2000-x86_64-Debug/expected-results.json View 1 2 chunks +1 line, -49 lines 0 comments Download
M expectations/gm/Test-Win7-ShuttleA-HD2000-x86_64-Release/expected-results.json View 1 2 chunks +1 line, -49 lines 0 comments Download
M expectations/gm/Test-Win8-ShuttleA-GTX660-x86-Debug/expected-results.json View 1 2 chunks +1 line, -70 lines 0 comments Download
M expectations/gm/Test-Win8-ShuttleA-GTX660-x86-Release/expected-results.json View 1 2 chunks +1 line, -70 lines 0 comments Download
M expectations/gm/Test-Win8-ShuttleA-GTX660-x86_64-Debug/expected-results.json View 1 2 chunks +1 line, -70 lines 0 comments Download
M expectations/gm/Test-Win8-ShuttleA-GTX660-x86_64-Release/expected-results.json View 1 2 chunks +1 line, -70 lines 0 comments Download
M expectations/gm/Test-Win8-ShuttleA-HD7770-x86-Debug/expected-results.json View 1 2 chunks +1 line, -49 lines 0 comments Download
M expectations/gm/Test-Win8-ShuttleA-HD7770-x86-Release/expected-results.json View 1 2 chunks +1 line, -49 lines 0 comments Download
M expectations/gm/Test-Win8-ShuttleA-HD7770-x86_64-Debug/expected-results.json View 1 2 chunks +1 line, -49 lines 0 comments Download
M expectations/gm/Test-Win8-ShuttleA-HD7770-x86_64-Release/expected-results.json View 1 2 chunks +1 line, -49 lines 0 comments Download
M experimental/webtry/templates/template.cpp View 1 chunk +0 lines, -1 line 0 comments Download
D gm/bicubicfilter.cpp View 1 chunk +0 lines, -86 lines 0 comments Download
M gyp/bench.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M gyp/effects.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M gyp/gmslides.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M gyp/public_headers.gypi View 1 chunk +0 lines, -1 line 0 comments Download
D include/effects/SkBicubicImageFilter.h View 1 chunk +0 lines, -56 lines 0 comments Download
M samplecode/SampleFilterFuzz.cpp View 3 chunks +1 line, -6 lines 0 comments Download
D src/effects/SkBicubicImageFilter.cpp View 1 chunk +0 lines, -204 lines 0 comments Download
M src/ports/SkGlobalInitialization_chromium.cpp View 2 chunks +0 lines, -2 lines 0 comments Download
M src/ports/SkGlobalInitialization_default.cpp View 2 chunks +0 lines, -2 lines 0 comments Download
M tests/ImageFilterTest.cpp View 2 chunks +0 lines, -17 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Stephen White
reed@: PTAL. Thanks!
6 years, 6 months ago (2014-06-25 19:40:41 UTC) #1
bsalomon
lgtm
6 years, 6 months ago (2014-06-25 21:22:57 UTC) #2
Stephen White
The CQ bit was checked by senorblanco@chromium.org
6 years, 6 months ago (2014-06-25 21:26:12 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/senorblanco@chromium.org/357793002/20001
6 years, 6 months ago (2014-06-25 21:26:59 UTC) #4
commit-bot: I haz the power
6 years, 6 months ago (2014-06-25 21:39:13 UTC) #5
Message was sent while issue was closed. 
Change committed as 7bf106847304840526a3e722b5ff5ce7322a2826

Powered by Google App Engine
This is Rietveld 408576698